Fix static analysis

Author: s-heppner

pyproject.toml

@@ -24,6 +24,8 @@ dev = [
     "mypy",
     "pycodestyle",
     "coverage",
+    "types-networkx",  # Type hints for networkx
+    "types-requests",   # Type hints for requests
 ]
 
 [tool.setuptools]

semantic_matcher/algorithm.py

@@ -132,7 +132,9 @@ def find_semantic_matches(
 
         # Traverse to the neighboring and therefore connected `semantic_id`s
         for neighbor, edge_data in graph[node].items():
-            new_score: float = score * edge_data["weight"]  # Multiplicative propagation
+            edge_weight = edge_data["weight"]
+            assert isinstance(edge_weight, float)
+            new_score: float = score * edge_weight  # Multiplicative propagation
 
             # Prevent loops by ensuring we do not revisit the start node after the first iteration
             if neighbor == semantic_id:

semantic_matcher/py.typed

@@ -80,7 +80,6 @@ def get_all_matches(self):
         matches = self.graph.get_all_matches()
         return matches
 
-
     def get_matches(
             self,
             request_body: MatchRequest
@@ -134,8 +133,6 @@ def get_matches(
                 score_limit=float(request_body.score_limit/match.score),
                 # If we already request a remote score, it does not make sense to choose `local_only`
                 local_only=False,
-                name=request_body.name,
-                definition=request_body.definition,
                 already_checked_locations=already_checked_locations
             )
             url = f"{remote_matching_service}/get_matches"

semantic_matcher/service.py

@@ -1,4 +1,4 @@
-import matplotlib.pyplot as plt
+import matplotlib.pyplot as plt  # type: ignore
 import networkx as nx
 
 from semantic_matcher.algorithm import SemanticMatchGraph

semantic_matcher/visualization.py

@@ -38,21 +38,21 @@ def test_get_all_matches_empty_graph(self):
         """Test that an empty graph returns an empty list."""
         empty_graph = algorithm.SemanticMatchGraph()
         matches = empty_graph.get_all_matches()
-        self.assertEqual([], matches,"Empty graph should return an empty list.")
+        self.assertEqual([], matches, "Empty graph should return an empty list.")
 
     def test_get_all_matches_duplicate_edges(self):
         """Test handling of duplicate edges with different scores."""
         self.graph.add_semantic_match("A", "B", 0.9)  # Overwriting edge
         matches = self.graph.get_all_matches()
 
         expected_matches = [
-            algorithm.SemanticMatch(base_semantic_id="A", match_semantic_id="B", score=0.9, path=[]),  # Overwritten edge
+            algorithm.SemanticMatch(base_semantic_id="A", match_semantic_id="B", score=0.9, path=[]),
             algorithm.SemanticMatch(base_semantic_id="B", match_semantic_id="C", score=0.6, path=[]),
             algorithm.SemanticMatch(base_semantic_id="C", match_semantic_id="D", score=0.9, path=[]),
         ]
 
         self.assertEqual(len(matches), 3, "Duplicate edge handling failed.")
-        self.assertCountEqual(expected_matches, matches,"Matches do not match expected results.")
+        self.assertCountEqual(expected_matches, matches, "Matches do not match expected results.")
 
     def test_get_all_matches_varying_weights(self):
         """Test that matches with different weights are retrieved correctly."""
@@ -352,5 +352,6 @@ def test_complex_graph(self):
         ]
         self.assertEqual(expected, matches_str)
 
+
 if __name__ == "__main__":
     unittest.main()

test/test_algorithm.py

@@ -84,7 +84,7 @@ def run_server_context():
             os.kill(server_process.pid, signal.SIGKILL)
             server_process.join()
 
-# @unittest.skip("These tests need to be adapted")
+
 class TestSemanticMatchingService(unittest.TestCase):
     def test_get_all_matches(self):
         with run_server_context():