Skip to content

Commit 2ab719c

Browse files
jwasingerfjl
authored andcommitted
accounts/abi/bind/v2: remove unecessary TODOs. Fix TestErrors compilation
1 parent 0a751f8 commit 2ab719c

File tree

3 files changed

+1
-4
lines changed

3 files changed

+1
-4
lines changed

accounts/abi/bind/v2/internal/contracts/events/contract.sol

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ contract C {
1111
uint256 data
1212
);
1313

14-
// TODO: consider log test where data is hashed? maybe not necessary for v2 coverage
1514
function EmitOne() public {
1615
emit basic1(
1716
uint256(1),

accounts/abi/bind/v2/lib.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,6 @@ func Transact(instance *ContractInstance, opts *bind.TransactOpts, input []byte)
165165
return c.RawTransact(opts, input)
166166
}
167167

168-
// TODO: test coverage for Call where the unpack method returns a pointer object.
169168
// Call performs an eth_call on the given bound contract instance, using the
170169
// provided abi-encoded input (or nil).
171170
func Call[T any](instance *ContractInstance, opts *bind.CallOpts, packedInput []byte, unpack func([]byte) (T, error)) (T, error) {

accounts/abi/bind/v2/lib_test.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -195,7 +195,6 @@ func TestDeploymentWithOverrides(t *testing.T) {
195195
}
196196
}
197197

198-
// TODO: constructor input packing should not return an error.
199198
ctrct, err := nested_libraries.NewC1()
200199
if err != nil {
201200
panic(err)
@@ -395,7 +394,7 @@ func TestErrors(t *testing.T) {
395394

396395
ctrctABI, _ := solc_errors.CMetaData.GetAbi()
397396
instance := ContractInstance{res.Addrs[solc_errors.CMetaData.Pattern], backend, *ctrctABI}
398-
_, err = Call[struct{}](&instance, opts, packedInput, func(packed []byte) (*struct{}, error) { return nil, nil })
397+
_, err = Call[struct{}](&instance, opts, packedInput, func(packed []byte) (struct{}, error) { return struct{}{}, nil })
399398
if err == nil {
400399
t.Fatalf("expected call to fail")
401400
}

0 commit comments

Comments
 (0)