add TODO note about cleaning up template code for return values

jwasinger · fjl · commit 4d2706c1c5d3 · 2025-01-22T13:54:58.000+01:00
diff --git a/accounts/abi/bind/source2.go.tpl b/accounts/abi/bind/source2.go.tpl
@@ -86,6 +86,7 @@ var (
 			  {{.Name}} {{bindtype .Type $structs}}{{end}}
 			}
 			{{ end }}
+			// TODO: if return count > 1, we return a struct.  no need to iterate .Normalized.Outputs here (but double-check this and remove this TODO once confirmed).
 			func ({{ decapitalise $contract.Type}} *{{$contract.Type}}) Unpack{{.Normalized.Name}}(data []byte) ({{if .Structured}} {{.Normalized.Name}}Output,{{else}}{{range .Normalized.Outputs}}{{bindtype .Type $structs}},{{end}}{{end}} error) {
 				out, err := {{ decapitalise $contract.Type}}.abi.Unpack("{{.Original.Name}}", data)
 				{{if .Structured}}

Original file line number	Diff line number	Diff line change
`@@ -86,6 +86,7 @@ var (`
`86`	`86`	`{{.Name}} {{bindtype .Type $structs}}{{end}}`
`87`	`87`	`}`
`88`	`88`	`{{ end }}`
	`89`	`+ // TODO: if return count > 1, we return a struct. no need to iterate .Normalized.Outputs here (but double-check this and remove this TODO once confirmed).`
`89`	`90`	`func ({{ decapitalise $contract.Type}} *{{$contract.Type}}) Unpack{{.Normalized.Name}}(data []byte) ({{if .Structured}} {{.Normalized.Name}}Output,{{else}}{{range .Normalized.Outputs}}{{bindtype .Type $structs}},{{end}}{{end}} error) {`
`90`	`91`	`out, err := {{ decapitalise $contract.Type}}.abi.Unpack("{{.Original.Name}}", data)`
`91`	`92`	`{{if .Structured}}`