Skip to content

Commit c7ff648

Browse files
jwasingerfjl
authored andcommitted
reenable TestBindingV2ConvertedV1Tests
1 parent 9dd006f commit c7ff648

File tree

1 file changed

+8
-10
lines changed

1 file changed

+8
-10
lines changed

accounts/abi/bind/bindv2_test.go

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ import (
66
"github.com/ethereum/go-ethereum/accounts/abi"
77
"github.com/ethereum/go-ethereum/crypto"
88
"os"
9-
"strings"
109
"testing"
1110
)
1211

@@ -345,20 +344,19 @@ func TestBindingV2ConvertedV1Tests(t *testing.T) {
345344

346345
// TODO: remove these before merging abigen2 PR. these are for convenience if I need to regenerate the converted bindings or add a new one.
347346

348-
if err := os.WriteFile(fmt.Sprintf("convertedv1bindtests/%s.go", strings.ToLower(tc.name)), []byte(code), 0666); err != nil {
349-
t.Fatalf("err writing expected output to file: %v\n", err)
350-
}
347+
/*
348+
if err := os.WriteFile(fmt.Sprintf("convertedv1bindtests/%s.go", strings.ToLower(tc.name)), []byte(code), 0666); err != nil {
349+
t.Fatalf("err writing expected output to file: %v\n", err)
350+
}*/
351351
/*
352352
fmt.Printf("//go:embed v2/internal/convertedv1bindtests/%s.go\n", strings.ToLower(tc.name))
353353
fmt.Printf("var v1TestBinding%s string\n", tc.name)
354354
fmt.Println()
355355
*/
356-
/*
357-
if code != tc.expectedBindings {
358-
//t.Fatalf("name mismatch for %s", tc.name)
359-
t.Fatalf("'%s'\n!=\n'%s'\n", code, tc.expectedBindings)
360-
}
361-
*/
356+
if code != tc.expectedBindings {
357+
//t.Fatalf("name mismatch for %s", tc.name)
358+
t.Fatalf("'%s'\n!=\n'%s'\n", code, tc.expectedBindings)
359+
}
362360
})
363361
}
364362
}

0 commit comments

Comments
 (0)