Skip to content

Commit 7065d94

Browse files
fix(ci): prevent partial releases on build failures (#361)
1 parent 5b6f4c3 commit 7065d94

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

.github/workflows/release-cli.yml

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ env:
1616

1717
jobs:
1818
update_helm_chart:
19-
needs: create_manifest
19+
needs: [create_manifest]
2020
runs-on: ubuntu-latest
2121
steps:
2222
- name: Generate GitHub token
@@ -79,7 +79,7 @@ jobs:
7979
name: ${{ matrix.target }}
8080
runs-on: ${{ matrix.os }}
8181
strategy:
82-
fail-fast: false
82+
fail-fast: true
8383
matrix:
8484
include:
8585
- os: ubuntu-22.04
@@ -169,10 +169,11 @@ jobs:
169169
if-no-files-found: error
170170

171171
build_images:
172+
needs: build_binaries
172173
name: Build ${{ matrix.arch }} Docker image
173174
runs-on: ${{ matrix.runner }}
174175
strategy:
175-
fail-fast: false
176+
fail-fast: true
176177
matrix:
177178
include:
178179
- arch: x86-64
@@ -251,7 +252,7 @@ jobs:
251252
${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}:latest-arm64
252253
253254
upload_release_artifacts:
254-
needs: build_binaries
255+
needs: [build_binaries, create_manifest]
255256
runs-on: ubuntu-22.04
256257
steps:
257258
- name: Checkout

0 commit comments

Comments
 (0)