Commit ecc54b2
test(amazonq): Set UI ready before executing amazonq e2e tests (aws#6580)
## Problem
- after
aws@19d0346
the listener adds messages in a buffer until the ui is ready. It looks
like some messages get caught in the buffer during tests since the mynah
ui activation is slightly different there
- The waitUntil was waiting until an event evaluated to true and then
afterwords checks to see if that same event is still true. This was
causing an issue where if the event originally evaluated to true and
then instantly evaluated to false, your tests would fail
## Solution
- manually set the ui ready after we've created the mynah ui instance in
tests
---
- Treat all work as PUBLIC. Private `feature/x` branches will not be
squash-merged at release time.
- Your code changes must meet the guidelines in
[CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines).
- License: I confirm that my contribution is made under the terms of the
Apache 2.0 license.1 parent 0e53435 commit ecc54b2
File tree
2 files changed
+10
-4
lines changed- packages/amazonq/test/e2e/amazonq/framework
2 files changed
+10
-4
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
79 | 79 | | |
80 | 80 | | |
81 | 81 | | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
82 | 88 | | |
83 | 89 | | |
84 | 90 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
190 | 190 | | |
191 | 191 | | |
192 | 192 | | |
193 | | - | |
194 | | - | |
195 | | - | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
196 | 196 | | |
197 | 197 | | |
198 | 198 | | |
| |||
202 | 202 | | |
203 | 203 | | |
204 | 204 | | |
205 | | - | |
| 205 | + | |
206 | 206 | | |
207 | 207 | | |
208 | 208 | | |
| |||
0 commit comments