Fixed a potential issue in GroupSingleCharacters

The pass should ignore meta expressions that do not represent a single character

Author: JoshyPHP

src/Passes/AbstractPass.php

@@ -9,6 +9,7 @@
 
 use const false, true;
 use function array_shift, array_unshift, count, end, is_array;
+use s9e\RegexpBuilder\Meta;
 
 abstract class AbstractPass implements PassInterface
 {
@@ -127,7 +128,7 @@ protected function isSingleAlternationString(array $string): bool
 	*/
 	protected function isSingleCharString(array $string): bool
 	{
-		return (count($string) === 1 && !is_array($string[0]));
+		return (count($string) === 1 && is_int($string[0]) && Meta::isChar($string[0]));
 	}
 
 	/**

tests/Passes/AbstractTest.php

@@ -3,6 +3,7 @@
 namespace s9e\RegexpBuilder\Tests\Passes;
 
 use PHPUnit\Framework\TestCase;
+use s9e\RegexpBuilder\Meta;
 
 abstract class AbstractTest extends TestCase
 {
@@ -22,4 +23,12 @@ public function getPassInstance()
 	}
 
 	abstract public function getPassTests();
+
+	protected function getMetaValue(string $expr): int
+	{
+		$meta = new Meta;
+		$meta->set('x', $expr);
+
+		return $meta->getInputMap()['x'];
+	}
 }

tests/Passes/GroupSingleCharactersTest.php

@@ -52,6 +52,29 @@ public function getPassTests()
 					[2, 2]
 				]
 			],
+			[
+				[
+					[1],
+					[2, 2],
+					[$this->getMetaValue('\\w')]
+				],
+				[
+					[[[1], [$this->getMetaValue('\\w')]]],
+					[2, 2]
+				]
+			],
+			[
+				[
+					[1],
+					[2, 2],
+					[$this->getMetaValue('.*')]
+				],
+				[
+					[1],
+					[2, 2],
+					[$this->getMetaValue('.*')]
+				]
+			],
 		];
 	}
 }