spartacus 2.39.4: Remove sourceforge from mirror list (#949)

* spartacus 2.39.4: Remove sourceforge from mirror list
Fixes #948

* minor: changelog version typo

Author: onli

docs/NEWS

@@ -1,6 +1,9 @@
 Version 2.6-beta2 ()
 ------------------------------------------------------------------------
 
+   * Removed Sourceforge from Spartacus' mirror list, as it caused HTML
+     to be written to the plugin files instead of the wanted PHP code.
+
    * Removed obsolete Pragma header from some responses, controlling
      brwoser cache behaviour. Alternative headers were already set.
 

plugins/serendipity_event_spartacus/ChangeLog

@@ -1,3 +1,8 @@
+2.39.4
+-------
+    * Fix: Sourceforge set as mirror caused HTML files being written to disk instead of the plugin
+           files when installing or updating plugins. Sourceforge has been removed.
+
 2.39.3
 -------
     * PHP8.2 compatibility

plugins/serendipity_event_spartacus/serendipity_event_spartacus.php

@@ -27,7 +27,7 @@ function introspect(&$propbag)
         $propbag->add('description',   PLUGIN_EVENT_SPARTACUS_DESC);
         $propbag->add('stackable',     false);
         $propbag->add('author',        'Garvin Hicking');
-        $propbag->add('version',       '2.39.3');
+        $propbag->add('version',       '2.39.4');
         $propbag->add('requirements',  array(
             'serendipity' => '1.6',
         ));
@@ -64,10 +64,6 @@ function introspect(&$propbag)
                     'url'  => 'http://www.s9y.org',
                     'desc' => 'Package server for plugin downloads'
                 ),
-                'sourceforge.net' => array(
-                    'url'  => 'http://www.sourceforget.net',
-                    'desc' => 'Package server for plugin downloads'
-                ),
                 'gitlab.com' => array(
                     'url'  => 'http://www.gitlab.com',
                     'desc' => 'Package server for plugin downloads'
@@ -126,7 +122,6 @@ function &getMirrors($type = 'xml', $loc = false)
 
             'files' => array(
                 'github.com',
-                'SourceForge.net',
                 's9y.org',
                 'gitlab.com'
             )
@@ -141,13 +136,11 @@ function &getMirrors($type = 'xml', $loc = false)
 
             'files' => array(
                 'https://raw.github.com/s9y/',
-                'http://php-blog.cvs.sourceforge.net/viewvc/php-blog/',
                 'http://s9y.org/mirror/',
                 'https://gitlab.com/s9y_blog/'
             ),
 
             'files_health' => array(
-                'http://php-blog.cvs.sourceforge.net/'  => 'http://php-blog.cvs.sourceforge.net/viewvc/php-blog/serendipity/docs/LICENSE',
                 'http://s9y.org/'                       => 'http://s9y.org/',
                 'https://raw.github.com/'               => 'https://raw.github.com/',
                 'https://gitlab.com/'               => 'https://gitlab.com/',
@@ -894,7 +887,11 @@ function &buildTemplateList(&$tree)
         $gitloc = '';
 
         $mirrors = $this->getMirrors('files', true);
-        $mirror  = $mirrors[$this->get_config('mirror_files', 0)];
+        $mirror_file_index = $this->get_config('mirror_files', 0);
+        if ($mirror_file_index > 2) {
+            $mirror_file_index = 0;
+        }
+        $mirror  = $mirrors[$mirror_file_index];
         if ($mirror == null) {
             $mirror = $mirrors[0];
         }
@@ -1064,7 +1061,11 @@ function download(&$tree, $plugin_to_install, $sub = 'plugins')
         }
 
         $mirrors = $this->getMirrors('files', true);
-        $mirror  = $mirrors[$this->get_config('mirror_files', 0)];
+        $mirror_file_index = $this->get_config('mirror_files', 0);
+        if ($mirror_file_index > 2) {
+            $mirror_file_index = 0;
+        }
+        $mirror  = $mirrors[$mirror_file_index];
         if ($mirror == null) {
             $mirror = $mirrors[0];
         }