Remove unnecessary flush()s, instead close OutputStream where it is constructed

Author: tpietzsch

src/main/java/org/janelia/saalfeldlab/n5/DefaultBlockWriter.java

@@ -57,6 +57,5 @@ static <T> void writeBlock(
 
 		final DataBlockCodec<T> codec = datasetAttributes.getDataBlockCodec();
 		codec.encode(dataBlock).writeTo(out);
-		out.flush();
 	}
 }

src/main/java/org/janelia/saalfeldlab/n5/GsonKeyValueN5Writer.java

@@ -26,6 +26,7 @@
 package org.janelia.saalfeldlab.n5;
 
 import java.io.IOException;
+import java.io.OutputStream;
 import java.io.UncheckedIOException;
 import java.util.Arrays;
 import java.util.List;
@@ -217,8 +218,11 @@ default <T> void writeBlock(
 			final DataBlock<T> dataBlock) throws N5Exception {
 
 		final String blockPath = absoluteDataBlockPath(N5URI.normalizeGroupPath(path), dataBlock.getGridPosition());
-		try (final LockedChannel lock = getKeyValueAccess().lockForWriting(blockPath)) {
-			DefaultBlockWriter.writeBlock(lock.newOutputStream(), datasetAttributes, dataBlock);
+		try (
+				final LockedChannel lock = getKeyValueAccess().lockForWriting(blockPath);
+				final OutputStream out = lock.newOutputStream()
+		) {
+			DefaultBlockWriter.writeBlock(out, datasetAttributes, dataBlock);
 		} catch (final IOException | UncheckedIOException e) {
 			throw new N5IOException(
 					"Failed to write block " + Arrays.toString(dataBlock.getGridPosition()) + " into dataset " + path,

src/main/java/org/janelia/saalfeldlab/n5/codec/N5Codecs.java

@@ -66,7 +66,6 @@ public ReadData encode(final DataBlock<T> dataBlock) throws IOException {
 			return ReadData.from(out -> {
 				new BlockHeader(dataBlock.getSize(), dataBlock.getNumElements()).writeTo(out);
 				compression.encode(dataCodec.serialize(dataBlock.getData())).writeTo(out);
-				out.flush();
 			});
 		}
 
@@ -104,7 +103,6 @@ public ReadData encode(final DataBlock<String[]> dataBlock) throws IOException {
 				final byte[] serializedData = flattenedArray.getBytes(ENCODING);
 				new BlockHeader(dataBlock.getSize(), serializedData.length).writeTo(out);
 				compression.encode(ReadData.from(serializedData)).writeTo(out);
-				out.flush();
 			});
 		}
 
@@ -137,7 +135,6 @@ public ReadData encode(final DataBlock<byte[]> dataBlock) throws IOException {
 			return ReadData.from(out -> {
 				new BlockHeader(null, dataBlock.getNumElements()).writeTo(out);
 				compression.encode(ReadData.from(dataBlock.getData())).writeTo(out);
-				out.flush();
 			});
 		}