Skip to content

Commit 5838dff

Browse files
Review of PR #31 (#41)
* feat: recursive approach instead of hardcoding protocols docs: natspec of deployment query fix: reverts when only chainId is passed in getAll function chore: adds missing rpc endpoints fix: tangle native token feat: adds missing parameters in CompilerSettings type fix: invalid undefined return when flatMap is used refactor: alphabetical order of Flow deployments fix: incorrect isLatest value for older Airdrops deployments fix: missing zksync broadcasts script: default just recipe * refactor: allow chainId in getAll * refactor: simpler definition for catalog --------- Co-authored-by: Paul Razvan Berg <[email protected]>
1 parent 6b935e0 commit 5838dff

File tree

15 files changed

+146
-67
lines changed

15 files changed

+146
-67
lines changed

data/lockup/v2.0/broadcasts-zk/zksync/LockupNFTDescriptor.json

Lines changed: 15 additions & 0 deletions
Large diffs are not rendered by default.
Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
{
2+
"sourceName": "contracts/libraries/NFTSVG.sol",
3+
"contractName": "NFTSVG",
4+
"abi": [],
5+
"bytecode": "0x00000001002001900000000c0000613d0000008001000039000000400010043f0000000001000416000000000001004b0000000c0000c13d00000020010000390000010000100443000001200000044300000005010000410000000f0001042e000000000100001900000010000104300000000e000004320000000f0001042e000000100001043000000000000000000000000000000000000000000000000000000002000000000000000000000000000000400000010000000000000000001ec8195dfdef4cc4ed46daf39c66b25ed24accb7f0de432a3554f27648374221",
6+
"entries": [
7+
{
8+
"constructorArgs": [],
9+
"salt": "0x0000000000000000000000000000000000000000000000000000000000000000",
10+
"deploymentType": "create",
11+
"factoryDeps": [],
12+
"address": "0x85599b3Dc35bed947F6D576B9516efcc184a2A87",
13+
"txHash": "0xf6672f58543e35ddcf0679a5ded54af49cf2a8abd6491ec0384042991b541039"
14+
}
15+
]
16+
}
Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
{
2+
"sourceName": "contracts/libraries/SVGElements.sol",
3+
"contractName": "SVGElements",
4+
"abi": [],
5+
"bytecode": "0x00000001002001900000000c0000613d0000008001000039000000400010043f0000000001000416000000000001004b0000000c0000c13d00000020010000390000010000100443000001200000044300000005010000410000000f0001042e000000000100001900000010000104300000000e000004320000000f0001042e000000100001043000000000000000000000000000000000000000000000000000000002000000000000000000000000000000400000010000000000000000003b528a507542029c3f4b04cd03fba069c09be44a8d7788048efaafbd3a048797",
6+
"entries": [
7+
{
8+
"constructorArgs": [],
9+
"salt": "0x0000000000000000000000000000000000000000000000000000000000000000",
10+
"deploymentType": "create",
11+
"factoryDeps": [],
12+
"address": "0x08d31504C1f7d070c5C33ab30B9d177481ca8300",
13+
"txHash": "0xa6c9c36589a7b43756cdea252180cfeb54301ecf3707a7d0c96ec99893019403"
14+
}
15+
]
16+
}

data/lockup/v2.0/broadcasts-zk/zksync/SablierBatchLockup.json

Lines changed: 15 additions & 0 deletions
Large diffs are not rendered by default.

data/lockup/v2.0/broadcasts-zk/zksync/SablierLockup.json

Lines changed: 19 additions & 0 deletions
Large diffs are not rendered by default.

justfile

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,8 @@ set shell := ["bash", "-euo", "pipefail", "-c"]
55
# ---------------------------------------------------------------------------- #
66

77
# Default recipe
8-
default: full-check
8+
default:
9+
just --list
910

1011
# Check code with Biome
1112
biome-check:

src/chains/config.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@ import type { Chain as ViemChain } from "viem/chains";
33
import * as viem from "viem/chains";
44
import { alchemyRPCs, infuraRPCs } from "./rpc";
55

6-
type ConfigString = { [chainId: number]: string };
76
type ConfigBool = { [chainId: number]: boolean };
7+
type ConfigString = { [chainId: number]: string };
88

99
export const config = {
1010
slugs: {

src/chains/mainnets.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,8 +53,8 @@ export const tangle: Sablier.Chain = fill(
5353
name: "Tangle",
5454
nativeCurrency: {
5555
decimals: 18,
56-
name: "Ether",
57-
symbol: "ETH",
56+
name: "Tangle",
57+
symbol: "TNT",
5858
},
5959
rpc: {
6060
public: "https://rpc.tangle.tools",

src/contracts/queries.ts

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,9 @@ import { catalog } from "./catalog";
55

66
export const contractsQueries = {
77
/**
8-
* Get a single contract by name or by address.
9-
* - {name, deployment}
10-
* - {name, release, chainId}
11-
* - {address}
8+
* Get a single contract using the following options:
9+
* - { chainId, name, release }
10+
* - { chainId, address, protocol }
1211
*/
1312
get: (opts: {
1413
chainId: number;

src/releases/airdrops/v1.1/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ export const deployments: Sablier.Deployment[] = [...mainnets, ...testnets];
99
export const release = resolvers.release.standard({
1010
aliases,
1111
deployments: deployments,
12-
isLatest: true,
12+
isLatest: false,
1313
manifest: manifest,
1414
protocol: Protocol.Airdrops,
1515
version: "v1.1",

0 commit comments

Comments
 (0)