Should we allow ERC20 tokens with 0 decimal value?

[smol-ninja]

^{Original discussed between @smol-ninja and @andreivladbrg on Slack.}

In create function, there is a check that revert if asset has 0 decimal:

flow/src/SablierV2OpenEnded.sol

Lines 487 to 490 in b5f70b6

	// Check: the asset does not have decimals.
	if (assetDecimals == 0) {
	revert Errors.SablierV2OpenEnded_InvalidAssetDecimals(asset);
	}

Decimal value plays a key role in normalising the amounts into 18 decimal format.

flow/src/SablierV2OpenEnded.sol

Lines 312 to 322 in b5f70b6

	// Determine if the asset's decimals are greater than 18.
	bool isGreaterThan18 = assetDecimals > 18;
	// Calculate the difference in decimals.
	uint8 normalizationFactor = isGreaterThan18 ? assetDecimals - 18 : 18 - assetDecimals;
	// Change the transfer amount based on the decimal difference.
	transferAmount = isGreaterThan18
	? (amount * (10 ** normalizationFactor)).toUint128()
	: (amount / (10 ** normalizationFactor)).toUint128();
	}

However, since the decimal value is not used in the denominator, it does not seem to create any calculation issues. I think that we should allow 0 decimal tokens, regardless of their demand, because fundamentally they are no different than any other ERC20 token.

Would love to hear your opinion @sablier-labs/engineers.

[smol-ninja]

@andreivladbrg do you see any problem with 0 decimal? Should we go ahead and remove 0 decimal check?

[andreivladbrg]

sorry for taking longer to answer to this

after thinking more about this i am also of the opinion that it is safe to use assets with 0 decimals

[andreivladbrg]

Issue created: #144