Have service.login() call expect(200) (getodk#752)

Author: matthew-white

test/integration/api/users.js

@@ -96,8 +96,9 @@ describe('api: /users', () => {
         asAlice.post('/v1/users')
           .send({ email: '[email protected]', password: '' })
           .expect(200) // treats a blank password as no password provided
-          .then(() => service.login({ email: '[email protected]', password: '' }, (failed) =>
-            failed.get('/v1/users/current').expect(401))))));
+          .then(() => service.post('/v1/sessions')
+            .send({ email: '[email protected]', password: '' })
+            .expect(400)))));
 
     it('should not accept a password that is too short', testService((service) =>
       service.login('alice', (asAlice) =>

test/integration/setup.js

@@ -131,7 +131,9 @@ const augment = (service) => {
       const credentials = (typeof user === 'string')
         ? { email: `${user}@getodk.org`, password: user }
         : user;
-      const { body } = await service.post('/v1/sessions').send(credentials);
+      const { body } = await service.post('/v1/sessions')
+        .send(credentials)
+        .expect(200);
       return body.token;
     }));
     const proxies = tokens.map((token) => new Proxy(service, authProxy(token)));