fix: spacing issues, clean up instructions role

Author: sadsfae

install/roles/fluentd/tasks/main.yml

@@ -48,11 +48,11 @@
 
     - name: Add Fluentd repository
       ansible.builtin.apt_repository:
-      repo: >-
-       deb https://packages.treasuredata.com/4/{{ ansible_distribution | lower }}/{{ ansible_distribution_release }}/
-       {{ ansible_distribution_release }} contrib
-       state: present
-       filename: fluentd
+        repo: >-
+          deb https://packages.treasuredata.com/4/{{ ansible_distribution | lower }}/{{ ansible_distribution_release }}/
+          {{ ansible_distribution_release }} contrib
+        state: present
+        filename: fluentd
 
     - name: Install fluentd
       ansible.builtin.apt:
@@ -95,24 +95,24 @@
         line: 'subjectAltName = "IP: {{ ansible_default_ipv4.address }}"'
         regexp: '^ Extensions for a typical CA'
         insertbefore: '# Extensions for a typical CA'
-        backup: yes
+        backup: true
       when: subject_alt_name_exists.stdout | int == 0
 
 - name: Install fluentd elasticsearch plugin
   community.general.gem:
     name: fluent-plugin-elasticsearch
     state: latest
-    include_dependencies: yes
-    user_install: no
+    include_dependencies: true
+    user_install: false
     executable: /usr/sbin/td-agent-gem
   become: true
 
 - name: Install fluentd beats plugin
   community.general.gem:
     name: fluent-plugin-beats
     state: latest
-    include_dependencies: yes
-    user_install: no
+    include_dependencies: true
+    user_install: false
     executable: /usr/sbin/td-agent-gem
   become: true
 

install/roles/instructions/tasks/main.yml

@@ -4,43 +4,52 @@
 #
 
 - name: Print SSL certificate post-setup information
-  debug: msg="Filebeat SSL Certificate available at http://{{ ansible_fqdn }}:{{ elk_server_ssl_cert_port }}/beat-forwarder.crt"
-  when: (logging_backend != 'fluentd')
+  debug:
+    msg: "Filebeat SSL Certificate available at http://{{ ansible_fqdn }}:{{ elk_server_ssl_cert_port }}/beat-forwarder.crt"
+  when: logging_backend != 'fluentd'
 
 - name: Print SSL key post-setup information
-  debug: msg="Filebeat SSL Certificate key is located at http://{{ ansible_fqdn }}:{{ elk_server_ssl_cert_port }}/beat-forwarder.key"
-  when: (logging_backend != 'fluentd')
+  debug:
+    msg: "Filebeat SSL Certificate key is located at http://{{ ansible_fqdn }}:{{ elk_server_ssl_cert_port }}/beat-forwarder.key"
+  when: logging_backend != 'fluentd'
 
 - name: Print post-setup URL for Apache
-  debug: msg="*** ELK Services available at http://{{ ansible_fqdn }}:{{ www_kibana_port }}/kibana ***"
-  when: apache_reverse_proxy|bool
+  debug:
+    msg: "*** ELK Services available at http://{{ ansible_fqdn }}:{{ www_kibana_port }}/kibana ***"
+  when: apache_reverse_proxy | bool
 
 - name: Print post-setup URL for nginx
-  debug: msg="*** ELK Services available at http://{{ ansible_fqdn }}:{{ www_kibana_port }} ***"
-  when: apache_reverse_proxy|bool
+  debug:
+    msg: "*** ELK Services available at http://{{ ansible_fqdn }}:{{ www_kibana_port }} ***"
+  when: apache_reverse_proxy | bool
 
 - name: Print index creation instructions
-  debug: msg="*** 1) Navigate to http://{{ ansible_fqdn }}:{{ www_kibana_port }} and login with {{kibana_user}}/{{kibana_password}} ***"
+  debug:
+    msg: "*** 1) Navigate to http://{{ ansible_fqdn }}:{{ www_kibana_port }} and login with {{ kibana_user }}/{{ kibana_password }} ***"
 
 - name: Print X-Pack instructions
-  debug: msg="*** 1A) (X-Pack only) Kibana account credentials login with elastic/{{xpack_elastic_user_password}} ***"
-  when: install_kibana_xpack|bool
+  debug:
+    msg: "*** 1A) (X-Pack only) Kibana account credentials login with elastic/{{ xpack_elastic_user_password }} ***"
+  when: install_kibana_xpack | bool
 
 - name: Print index creation more instructions
-  debug: msg="*** 2) Navigate to Discover (left-hand corner) --> Kibana (index patterns) ***"
+  debug:
+    msg: "*** 2) Navigate to Discover (left-hand corner) --> Kibana (index patterns) ***"
 
 - name: Print index creation more instructions
-  debug: msg="*** 3) Type logstash-* into the index creation name and click Next ***"
+  debug:
+    msg: "*** 3) Type logstash-* into the index creation name and click Next ***"
 
 - name: Print Index creation more instructions
-  debug: msg="*** 4) Select '@timestamp' under 'Time-field name' and Create Index Pattern ***"
+  debug:
+    msg: "*** 4) Select '@timestamp' under 'Time-field name' and Create Index Pattern ***"
 
 - name: Print Navigation Instructions
-  debug: msg="*** 5) Click on Discover ***"
+  debug:
+    msg: "*** 5) Click on Discover ***"
 
 - name: Print filebeat client setup instructions
   debug:
-    "msg": [
-      "*** 6) ansible-playbook -i hosts install/elk_client.yml --extra-vars 'elk_server={{ ansible_default_ipv4.address }}' to setup clients",
-      "*** To add new clients later, running only this command above is needed ***"
-    ]
+    msg:
+      - "*** 6) ansible-playbook -i hosts install/elk_client.yml --extra-vars 'elk_server={{ ansible_default_ipv4.address }}' to setup clients"
+      - "*** To add new clients later, running only this command above is needed ***"