Deprecate malysis active scanner (#155)

* deprecate malysis active scanner

* Update config/config.go

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Sahil Bansal <bansalsahil315@gmail.com>

* copilot fixes

---------

Signed-off-by: Sahil Bansal <bansalsahil315@gmail.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Author: Sahilb315

README.md

@@ -171,17 +171,6 @@ This will:
 
 ## Usage
 
-<details>
-<summary>Active Scanning</summary>
-
-Use the `--paranoid` flag to perform active malware scanning on unknown packages (requires [SafeDep Cloud credentials](https://docs.safedep.io/cloud/authentication#api-key-authentication)):
-
-```bash
-pmg --paranoid npm install <package-name>
-```
-
-</details>
-
 <details>
 <summary>Silent Mode</summary>
 

analyzer/malysis_active_scan.go

@@ -16,7 +16,7 @@ func ApplyCobraFlags(cmd *cobra.Command) {
 	cmd.PersistentFlags().BoolVar(&globalConfig.DryRun, "dry-run",
 		globalConfig.DryRun, "Dry run skips execution of package manager")
 	cmd.PersistentFlags().BoolVar(&globalConfig.Config.Paranoid, "paranoid",
-		globalConfig.Config.Paranoid, "Perform active scanning of unknown packages (slow)")
+		globalConfig.Config.Paranoid, "Enable high-security defaults (treat suspicious as malicious)")
 	cmd.PersistentFlags().BoolVar(&globalConfig.Config.SkipEventLogging, "skip-event-log",
 		globalConfig.Config.SkipEventLogging, "Skip event logging")
 	cmd.PersistentFlags().BoolVar(&globalConfig.Config.ExperimentalProxyMode, "experimental-proxy-mode",

config/cobra.go

@@ -44,7 +44,7 @@ type Config struct {
 	TransitiveDepth        int  `mapstructure:"transitive_depth"`
 	IncludeDevDependencies bool `mapstructure:"include_dev_dependencies"`
 
-	// Paranoid mode enables active scanning of unknown packages for malware.
+	// Paranoid enables high-security defaults (e.g., treating suspicious behavior as malicious).
 	Paranoid bool `mapstructure:"paranoid"`
 
 	// TrustedPackages allows for trusting a suspicious package and ignoring the suspicious behaviour for the package in future installations

config/config.go

@@ -57,22 +57,13 @@ func (f *commonFlow) Run(ctx context.Context, args []string, parsedCmd *packagem
 
 	startTime := time.Now()
 
-	if cfg.Config.Paranoid {
-		malysisActiveScanAnalyzer, err := analyzer.NewMalysisActiveScanAnalyzer(analyzer.DefaultMalysisActiveScanAnalyzerConfig())
-		if err != nil {
-			return fmt.Errorf("failed to create malware analyzer: %s", err)
-		}
-
-		analyzers = append(analyzers, malysisActiveScanAnalyzer)
-	} else {
-		malysisQueryAnalyzer, err := analyzer.NewMalysisQueryAnalyzer(analyzer.MalysisQueryAnalyzerConfig{})
-		if err != nil {
-			return fmt.Errorf("failed to create malware analyzer: %s", err)
-		}
-
-		analyzers = append(analyzers, malysisQueryAnalyzer)
+	malysisQueryAnalyzer, err := analyzer.NewMalysisQueryAnalyzer(analyzer.MalysisQueryAnalyzerConfig{})
+	if err != nil {
+		return fmt.Errorf("failed to create malware analyzer: %w", err)
 	}
 
+	analyzers = append(analyzers, malysisQueryAnalyzer)
+
 	interaction := guard.PackageManagerGuardInteraction{
 		SetStatus:                ui.SetStatus,
 		ClearStatus:              ui.ClearStatus,

internal/flows/common_flow.go

@@ -242,14 +242,6 @@ func (f *proxyFlow) createCertificateManager(caCert *certmanager.Certificate) (c
 
 // createAnalyzer creates the malysis query analyzer
 func (f *proxyFlow) createAnalyzer() (analyzer.PackageVersionAnalyzer, error) {
-	cfg := config.Get()
-
-	// Use paranoid mode (active scan) if enabled, otherwise use query mode
-	if cfg.Config.Paranoid {
-		log.Debugf("Creating malysis active scan analyzer (paranoid mode)")
-		return analyzer.NewMalysisActiveScanAnalyzer(analyzer.DefaultMalysisActiveScanAnalyzerConfig())
-	}
-
 	log.Debugf("Creating malysis query analyzer")
 	return analyzer.NewMalysisQueryAnalyzer(analyzer.MalysisQueryAnalyzerConfig{})
 }