update pmg banner & fix empty commit (#127)

* update pmg banner & fix empty commit

* rm old banner

* precompile regex for version

* fix: Color in github URL (#128)

---------

Co-authored-by: Abhisek Datta <abhisek.datta@gmail.com>

Author: Sahilb315

internal/ui/banner.go

@@ -2,26 +2,53 @@ package ui
 
 import (
 	"fmt"
+	"regexp"
+	"strings"
 
 	"github.com/fatih/color"
 )
 
 var (
-	brandPinkRed = color.RGB(219, 39, 119).Add(color.Bold).SprintFunc() // 	#DB2777 Brand Pink
-	whiteDim     = color.New(color.Faint).SprintFunc()
+	brandPinkRed  = color.RGB(219, 39, 119).Add(color.Bold).SprintFunc() // 	#DB2777 Brand Pink
+	whiteDim      = color.New(color.Faint).SprintFunc()
+	pseudoPattern = regexp.MustCompile(`^(v?\d+\.\d+\.\d+)-0\.\d{14}-[a-f0-9]{12}$`)
 )
 
 func GeneratePMGBanner(version, commit string) string {
-	var pmgASCIIText = `
-█▀█ █▀▄▀█ █▀▀	From SafeDep
-█▀▀ █░▀░█ █▄█` // It should end here no \n
+	// Build the first line with a differently colored URL segment
+	line1 := fmt.Sprintf("%s\tFrom SafeDep %s", brandPinkRed("█▀█ █▀▄▀█ █▀▀"), whiteDim("(github.com/safedep/pmg)"))
+	line2 := brandPinkRed("█▀▀ █░▀░█ █▄█")
+
+	pmgASCIIText := "\n" + line1 + "\n" + line2 // It should end here no \n
 
 	if len(commit) >= 6 {
 		commit = commit[:6]
 	}
 
-	return fmt.Sprintf("%s 	%s: %s %s: %s\n\n", brandPinkRed(pmgASCIIText),
+	// Clean version to remove pseudo-version complexity
+	version = cleanVersion(version)
+
+	return fmt.Sprintf("%s 	%s: %s %s: %s\n\n", pmgASCIIText,
 		whiteDim("version"), Colors.Bold(version),
 		whiteDim("commit"), Colors.Bold(commit),
 	)
 }
+
+// cleanVersion removes ugly pseudo-version timestamps and dirty flags
+// Keeps clean versions like v1.2.3-alpha.1 and v0.3.5-edfdd54 as-is
+func cleanVersion(version string) string {
+	if version == "" {
+		return version
+	}
+
+	// Remove build metadata (+dirty, +build.1, etc.)
+	version = strings.Split(version, "+")[0]
+
+	// Only clean pseudo-versions with timestamps
+	// Pattern: v1.2.3-0.20220101123456-abcdef123456
+	if matches := pseudoPattern.FindStringSubmatch(version); len(matches) > 1 {
+		return matches[1]
+	}
+
+	return version
+}

internal/version/version.go

@@ -8,8 +8,21 @@ var (
 )
 
 func init() {
+	buildInfo, ok := runtimeDebug.ReadBuildInfo()
+	if !ok {
+		return
+	}
+
 	if Version == "" {
-		buildInfo, _ := runtimeDebug.ReadBuildInfo()
 		Version = buildInfo.Main.Version
 	}
+
+	if Commit == "" {
+		for _, setting := range buildInfo.Settings {
+			if setting.Key == "vcs.revision" {
+				Commit = setting.Value
+				break
+			}
+		}
+	}
 }