Use only randomChars for helper testacc (part2)

Author: MalloZup

libvirt/resource_libvirt_coreos_ignition_test.go

@@ -13,7 +13,7 @@ import (
 func TestAccLibvirtIgnition_Basic(t *testing.T) {
 	var volume libvirt.StorageVol
 	randomServiceName := acctest.RandStringFromCharSet(10, acctest.CharSetAlpha) + ".service"
-	randomIgnitionName := acctest.RandString(9)
+	randomIgnitionName := acctest.RandStringFromCharSet(10, acctest.CharSetAlpha)
 	var config = fmt.Sprintf(`
 	data "ignition_systemd_unit" "acceptance-test-systemd" {
 		name    = "%s"

libvirt/resource_libvirt_domain_test.go

@@ -123,7 +123,7 @@ func TestAccLibvirtDomain_VolumeTwoDisks(t *testing.T) {
 	var domain libvirt.Domain
 	var volume libvirt.StorageVol
 	randomVolumeName := acctest.RandStringFromCharSet(10, acctest.CharSetAlpha)
-	randomVolumeName2 := acctest.RandString(9)
+	randomVolumeName2 := acctest.RandStringFromCharSet(10, acctest.CharSetAlpha)
 	randomDomainName := acctest.RandStringFromCharSet(10, acctest.CharSetAlpha)
 
 	var configVolAttached = fmt.Sprintf(`
@@ -182,7 +182,7 @@ func TestAccLibvirtDomain_VolumeDriver(t *testing.T) {
 	var volumeRaw libvirt.StorageVol
 	var volumeQCOW2 libvirt.StorageVol
 	randomVolumeQCOW2 := acctest.RandStringFromCharSet(10, acctest.CharSetAlpha)
-	randomVolumeRaw := acctest.RandString(9)
+	randomVolumeRaw := acctest.RandStringFromCharSet(10, acctest.CharSetAlpha)
 	randomDomainName := acctest.RandStringFromCharSet(10, acctest.CharSetAlpha)
 
 	var config = fmt.Sprintf(`

libvirt/resource_libvirt_pool_test.go

@@ -61,8 +61,8 @@ func testAccCheckLibvirtPoolDoesNotExists(n string, pool *libvirt.StoragePool) r
 
 func TestAccLibvirtPool_Basic(t *testing.T) {
 	var pool libvirt.StoragePool
-	randomPoolResource := acctest.RandString(10)
-	randomPoolName := acctest.RandString(10)
+	randomPoolResource := acctest.RandStringFromCharSet(10, acctest.CharSetAlpha)
+	randomPoolName := acctest.RandStringFromCharSet(10, acctest.CharSetAlpha)
 	poolPath := "/tmp/cluster-api-provider-libvirt-pool-" + randomPoolName
 	resource.Test(t, resource.TestCase{
 		PreCheck:     func() { testAccPreCheck(t) },
@@ -94,8 +94,8 @@ func TestAccLibvirtPool_Basic(t *testing.T) {
 // This test should fail without a proper "Exists" implementation
 func TestAccLibvirtPool_ManuallyDestroyed(t *testing.T) {
 	var pool libvirt.StoragePool
-	randomPoolResource := acctest.RandString(10)
-	randomPoolName := acctest.RandString(10)
+	randomPoolResource := acctest.RandStringFromCharSet(10, acctest.CharSetAlpha)
+	randomPoolName := acctest.RandStringFromCharSet(10, acctest.CharSetAlpha)
 	poolPath := "/tmp/cluster-api-provider-libvirt-pool-" + randomPoolName
 	testAccCheckLibvirtPoolConfigBasic := fmt.Sprintf(`
 	resource "libvirt_pool" "%s" {
@@ -131,9 +131,9 @@ func TestAccLibvirtPool_ManuallyDestroyed(t *testing.T) {
 }
 
 func TestAccLibvirtPool_UniqueName(t *testing.T) {
-	randomPoolName := acctest.RandString(10)
-	randomPoolResource2 := acctest.RandString(10)
-	randomPoolResource := acctest.RandString(10)
+	randomPoolName := acctest.RandStringFromCharSet(10, acctest.CharSetAlpha)
+	randomPoolResource2 := acctest.RandStringFromCharSet(10, acctest.CharSetAlpha)
+	randomPoolResource := acctest.RandStringFromCharSet(10, acctest.CharSetAlpha)
 	poolPath := "/tmp/cluster-api-provider-libvirt-pool-" + randomPoolName
 	poolPath2 := "/tmp/cluster-api-provider-libvirt-pool-" + randomPoolName + "-2"
 	config := fmt.Sprintf(`
@@ -164,8 +164,8 @@ func TestAccLibvirtPool_UniqueName(t *testing.T) {
 }
 
 func TestAccLibvirtPool_NoDirPath(t *testing.T) {
-	randomPoolResource := acctest.RandString(10)
-	randomPoolName := acctest.RandString(10)
+	randomPoolResource := acctest.RandStringFromCharSet(10, acctest.CharSetAlpha)
+	randomPoolName := acctest.RandStringFromCharSet(10, acctest.CharSetAlpha)
 	resource.Test(t, resource.TestCase{
 		PreCheck:     func() { testAccPreCheck(t) },
 		Providers:    testAccProviders,