Merge pull request dmacvicar#598 from dmacvicar/fix_cd_on_virtio

Fix unsupported configuration "'unsupported configuration: disk type 'virtio' of 'vda' does not support ejectable media')"

Author: MalloZup

libvirt/domain.go

@@ -500,7 +500,16 @@ func setDisks(d *schema.ResourceData, domainDef *libvirtxml.Domain, virConn *lib
 
 			if strings.HasSuffix(url.Path, ".iso") {
 				disk.Device = "cdrom"
+				disk.Target = &libvirtxml.DomainDiskTarget{
+					Dev: fmt.Sprintf("hd%s", diskLetterForIndex(numOfISOs)),
+					Bus: "ide",
+				}
+				disk.Driver = &libvirtxml.DomainDiskDriver{
+					Name: "qemu",
+				}
+				numOfISOs++
 			}
+
 			if !strings.HasSuffix(url.Path, ".qcow2") {
 				disk.Driver.Type = "raw"
 			}
@@ -525,6 +534,10 @@ func setDisks(d *schema.ResourceData, domainDef *libvirtxml.Domain, virConn *lib
 
 				numOfISOs++
 			}
+
+			if !strings.HasSuffix(file.(string), ".qcow2") {
+				disk.Driver.Type = "raw"
+			}
 		}
 
 		domainDef.Devices.Disks = append(domainDef.Devices.Disks, disk)