Add a callback function

[AryanSingh]

Please add functionality to add a callback function after someone clicks outside a box.

[sag1v]

Can you please provide a use case for this?
When should this callback fire, before or after the state updates and trigger a re-render?

[AryanSingh]

I have a modal, I want to close the modal when clicked outside it. I used react-trap to check for clicks outside modal, i want to close the modal when clicked outside.

[sag1v]

Not sure i fully understand.
react-trap is already providing the value for you, you can pass it to the Modal as a prop:

<Trap event="click">
    {(trapped, ref) => <Modal innerRef={ref} isOpen={trapped} />}
</Trap>

Is this not answering your use case?

[sag1v]

closing for now. feel free to reopen if you think my solution isn't sufficient

[sag1v]

I think i realized the motivation here, hence I'm reopening this issue. i think a callback can help indeed

[AryanSingh]

Thanks man, i appreciate it. Your code is beautifully written. May i know your coding background, which language you have worked on.

…

On Sun 17 Mar, 2019, 5:31 PM Sagiv ben giat, ***@***.***> wrote: I think i realized the motivation here, hence I'm reopening this issue. i think a callback can help indeed — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AMkKSLndLjN3zErHQpF1f1qqACMWr-i6ks5vXi6BgaJpZM4ajNRt> .

[sag1v]

Thank you, mostly c# and JavaScript of course