Trac #33151: sage-conf_pypi does not build wheelhouse

Contrary to what is claimed in the README in https://pypi.org/project
/sage-conf/9.5rc0/, after `pip install  sage_conf==9.5rc0`, there is no
wheelhouse available: `ls $(sage-config SAGE_SPKG_WHEELS)` gives "No
such file or directory".

We fix this by changing `make build-local` to `make build` in the
install script (and fixing a bug that caused `make build` to fail).

Distribution using the branch of this ticket uploaded as
https://pypi.org/project/sage-conf/9.5rc0.post1/

URL: https://trac.sagemath.org/33151
Reported by: mkoeppe
Ticket author(s): Matthias Koeppe
Reviewer(s): Dima Pasechnik

Author: Release Manager

configure.ac

@@ -446,6 +446,14 @@ AS_IF([test "x$enable_download_from_upstream_url" = "xyes"], [
 ])
 AC_SUBST([SAGE_SPKG_OPTIONS])
 
+AC_ARG_ENABLE([sagelib],
+  AS_HELP_STRING([--disable-sage_conf],
+                 [disable build of the sage_conf package]), [
+    for pkg in sage_conf; do
+      AS_VAR_SET([SAGE_ENABLE_$pkg], [$enableval])
+    done
+  ])
+
 AC_ARG_ENABLE([cvxopt],
   AS_HELP_STRING([--disable-cvxopt],
                  [disable build of the cvxopt package and its prerequisite suitesparse]), [
@@ -490,7 +498,7 @@ AC_ARG_ENABLE([doc],
 AC_ARG_ENABLE([sagelib],
   AS_HELP_STRING([--disable-sagelib],
                  [disable build of the Sage library and packages depending on it]), [
-    for pkg in sagelib sage_docbuild; do
+    for pkg in sagelib sage_docbuild sage_setup; do
       AS_VAR_SET([SAGE_ENABLE_$pkg], [$enableval])
     done
   ])

pkgs/sage-conf/README.rst

@@ -22,8 +22,8 @@ sage_conf sdist on PyPI
 -----------------------
 
 This implementation of the ``sage_conf`` distribution package comes from
-https://trac.sagemath.org/ticket/29039, which adds the directory
-``pkgs/sage-conf_pypi/``.
+https://trac.sagemath.org/ticket/29039, which added the directory
+`pkgs/sage-conf_pypi <https://github.com/sagemath/sage/tree/develop/pkgs/sage-conf_pypi/>`_.
 
 To install, use ``pip install -v sage_conf``.  Using ``-v`` ensures that diagnostic
 messages are displayed.
@@ -77,8 +77,9 @@ sage_conf in the SageMath distribution
 
 The original version of the distribution package ``sage_conf`` is used
 internally in the SageMath distribution.  It is provided in the directory
-``pkgs/sage-conf/``.  This version of the package is generated
-by the Sage distribution's ``configure`` script.
+`pkgs/sage-conf <https://github.com/sagemath/sage/tree/develop/pkgs/sage-conf/>`_.
+This version of the package is generated by the Sage distribution's ``configure``
+script.
 
 
 sage_conf in downstream distributions
@@ -100,4 +101,4 @@ Upstream Contact
 https://www.sagemath.org
 
 This package is included in the source code of the Sage distribution,
-in ``pkgs/sage-conf*``.
+in `pkgs/sage-conf* <https://github.com/sagemath/sage/tree/develop/pkgs/>`_.

pkgs/sage-conf_pypi/setup.py

@@ -37,7 +37,7 @@ def run(self):
                 shutil.copytree('sage_root', SAGE_ROOT)  # will fail if already exists
             except Exception:
                 raise DistutilsSetupError(f"the directory SAGE_ROOT={SAGE_ROOT} already exists but it is not configured.  Please remove it and try again.")
-            cmd = f"cd {SAGE_ROOT} && {SETENV} && ./configure --prefix={SAGE_LOCAL} --with-python={sys.executable} --enable-build-as-root --enable-download-from-upstream-url --with-system-python3=force --with-sage-venv --disable-notebook --disable-sagelib"
+            cmd = f"cd {SAGE_ROOT} && {SETENV} && ./configure --prefix={SAGE_LOCAL} --with-python={sys.executable} --enable-build-as-root --enable-download-from-upstream-url --with-system-python3=force --with-sage-venv --disable-notebook --disable-sagelib --disable-sage_conf --disable-doc"
             print(f"Running {cmd}")
             sys.stdout.flush()
             if os.system(cmd) != 0:
@@ -55,9 +55,11 @@ def run(self):
         # TODO: A target to only build wheels of tricky packages
         # (that use native libraries shared with other packages).
         SETMAKE = 'if [ -z "$MAKE" ]; then export MAKE="make -j$(PATH=build/bin:$PATH build/bin/sage-build-num-threads | cut -d" " -f 2)"; fi'
-        cmd = f'cd {SAGE_ROOT} && {SETENV} && {SETMAKE} && $MAKE V=0 build-local'
+        TARGETS = 'build'
+        cmd = f'cd {SAGE_ROOT} && {SETENV} && {SETMAKE} && $MAKE V=0 {TARGETS}'
+        print(f"Running {cmd}", flush=True)
         if os.system(cmd) != 0:
-            raise DistutilsSetupError("make build-local failed")
+            raise DistutilsSetupError(f"make {TARGETS} failed")
 
         # Install configuration
         shutil.copyfile(os.path.join(SAGE_ROOT, 'pkgs', 'sage-conf', 'sage_conf.py'),