Skip to content
This repository was archived by the owner on Feb 1, 2023. It is now read-only.

Commit 6096110

Browse files
author
Release Manager
committed
Trac #30517: MemoryError in doctesting combinat/designs/gen_quadrangles_with_spread.pyx
There are numerous `MemoryError` instances in doctesting `gen_quadrangles_with_spread.pyx` with a final failure {{{ ---------------------------------------------------------------------- sage -t --long --warn-long 127.5 --random-seed=0 src/sage/combinat/designs/gen_quadrangles_with_spread.pyx # Bad exit: 1 ---------------------------------------------------------------------- Total time for all tests: 108.3 seconds cpu time: 0.0 seconds cumulative wall time: 0.0 seconds }}} See ticket #30223 for background. URL: https://trac.sagemath.org/30517 Reported by: strogdon Ticket author(s): Volker Braun, Frederic Chapoton Reviewer(s): Dima Pasechnik
2 parents e67fc51 + c40efe9 commit 6096110

File tree

1 file changed

+16
-16
lines changed

1 file changed

+16
-16
lines changed

src/sage/combinat/designs/gen_quadrangles_with_spread.pyx

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ REFERENCES:
2525
- [TP1994]_
2626
2727
- :wikipedia:`Generalized_quadrangle`
28-
28+
2929
AUTHORS:
3030
3131
- Ivo Maffei (2020-07-26): initial version
@@ -96,7 +96,7 @@ def generalised_quadrangle_with_spread(const int s, const int t,
9696
from sage.combinat.designs.incidence_structures import IncidenceStructure
9797
from sage.misc.unknown import Unknown
9898
from sage.arith.misc import is_prime_power
99-
99+
100100
if s < 1 or t < 1:
101101
if existence:
102102
return False
@@ -127,11 +127,11 @@ def is_GQ_with_spread(GQ, S, s=None, t=None):
127127
check that S is a spread of GQ
128128
129129
INPUT:
130-
131-
- ``GQ`` -- IncidenceStructure; the incidence structure that is supposed to
130+
131+
- ``GQ`` -- IncidenceStructure; the incidence structure that is supposed to
132132
be a generalised quadrangle
133133
134-
- ``S`` -- iterable; the spread of ``GQ`` as an
134+
- ``S`` -- iterable; the spread of ``GQ`` as an
135135
iterable of the blocks of ``GQ``
136136
137137
- ``s, t`` -- integers (optional); if `(s,t)` are given, then we check that
@@ -175,32 +175,32 @@ def is_GQ_with_spread(GQ, S, s=None, t=None):
175175

176176
def dual_GQ_ovoid(GQ, O):
177177
r"""
178-
Compute the dual incidence structure of GQ
178+
Compute the dual incidence structure of GQ
179179
and return the image of `O` under the dual map
180180
181181
INPUT:
182182
183-
- ``GQ`` -- IncidenceStructure; the generalised quadrangle we want
183+
- ``GQ`` -- IncidenceStructure; the generalised quadrangle we want
184184
the dual of
185185
186186
- ``O`` -- iterable; the iterable of blocks we want to compute the dual
187187
188188
OUTPUT:
189189
190-
A pair ``(D, S)`` where ``D`` is the dual of ``GQ`` and
190+
A pair ``(D, S)`` where ``D`` is the dual of ``GQ`` and
191191
``S`` is the dual of ``O``
192192
193193
EXAMPLES::
194-
194+
195195
sage: from sage.combinat.designs.gen_quadrangles_with_spread import \
196196
....: dual_GQ_ovoid
197197
sage: t = designs.generalised_quadrangle_hermitian_with_ovoid(3)
198198
sage: t[0].is_generalized_quadrangle(parameters=True)
199199
(9, 3)
200200
sage: t = dual_GQ_ovoid(*t)
201-
sage: t[0].is_generalized_quadrangle(parameters=True)
201+
sage: t[0].is_generalized_quadrangle(parameters=True) # known bug
202202
(3, 9)
203-
sage: all([x in t[0] for x in t[1]])
203+
sage: all([x in t[0] for x in t[1]]) # known bug
204204
True
205205
206206
@@ -213,10 +213,10 @@ def dual_GQ_ovoid(GQ, O):
213213
(2, 4)
214214
sage: is_GQ_with_spread(*t)
215215
True
216-
216+
217217
"""
218218
from sage.combinat.designs.incidence_structures import IncidenceStructure
219-
219+
220220
# GQ.ground_set()[i] becomes newBlocks[i]
221221
# GQ.blocks()[i] becomes i
222222
newBlocks = [[] for _ in range(GQ.num_points())]
@@ -271,7 +271,7 @@ def generalised_quadrangle_hermitian_with_ovoid(const int q):
271271
is_GQ_with_spread, dual_GQ_ovoid
272272
sage: t = designs.generalised_quadrangle_hermitian_with_ovoid(3)
273273
sage: t = dual_GQ_ovoid(*t)
274-
sage: is_GQ_with_spread(*t, s=3, t=9)
274+
sage: is_GQ_with_spread(*t, s=3, t=9) # known bug
275275
True
276276
sage: t = dual_GQ_ovoid(*(
277277
....: designs.generalised_quadrangle_hermitian_with_ovoid(2)))
@@ -283,7 +283,7 @@ def generalised_quadrangle_hermitian_with_ovoid(const int q):
283283
from sage.libs.gap.libgap import libgap
284284
from sage.combinat.designs.incidence_structures import IncidenceStructure
285285
from sage.arith.misc import is_prime_power
286-
286+
287287
GU = libgap.GU(4, q)
288288
H = libgap.InvariantSesquilinearForm(GU)["matrix"]
289289
Fq = libgap.GF(q * q)
@@ -328,7 +328,7 @@ def generalised_quadrangle_hermitian_with_ovoid(const int q):
328328
J = [[0, 0, 0, 0, 1], [0, 0, 0, 1, 0], [0, 0, 1, 0, 0],
329329
[0, 1, 0, 0, 0], [1, 0, 0, 0, 0]]
330330
J = libgap(J) # matrix of the invariant form of GU(5,q)
331-
331+
332332
# p' is collinear to p iff p'Jp^q = 0
333333
# note that p'Jp^q = bx^q + c where p' = (a,b,0,c,d) and p = (0,1,y,x,0)
334334
ovoid = []

0 commit comments

Comments
 (0)