Trac #29521: Modify giac upstream tarball to remove non-portable filenames

http://www-fourier.ujf-
grenoble.fr/~parisse/debian/dists/stable/main/source/

When preparing the reduced tarball with `spkg-src`,
we should rename the non-portable file names with a colon in them:

{{{
$ find . -name "*:*"
./doc/pari/Programming_in_GP:_control_statements.html
./doc/pari/Programming_in_GP:_other_specific_functions.html
./doc/pari/cont_Programming_in_GP:_other_specific_functions.html
./doc/pari/cont_Programming_in_GP:_control_statements.html
}}}

(problematic at least on Windows - as reported in #28549.)

Previous updates:
- #26315 Upgrade to Giac 1.5
- #28101 update giac to 1.5.0-63

Follow-up: #29552 (Upgrade giac to 1.5.0-87) ... for Sage 9.2

URL: https://trac.sagemath.org/29521
Reported by: mkoeppe
Ticket author(s): Matthias Koeppe
Reviewer(s): François Bissey, Dima Pasechnik

Author: Release Manager

build/pkgs/giac/checksums.ini

@@ -1,4 +1,5 @@
 tarball=giac-VERSION.tar.bz2
-sha1=7ea2f353b7f63f484d38fe86c5720c82d770c69c
-md5=652634cf95590a5601d17c90c3fc410c
-cksum=2772110213
+sha1=eadeb7194b1809298a0d94642d94c8dff80bbe3d
+md5=7760e342f5e5b3f5da0f1b9c15546b96
+cksum=1678878999
+upstream_url=https://trac.sagemath.org/raw-attachment/ticket/29521/giac-1.5.0.63-p0.tar.bz2

build/pkgs/giac/package-version.txt

@@ -1 +1 @@
-1.5.0.63.p0
+1.5.0.63-p0

build/pkgs/giac/spkg-src

@@ -15,21 +15,22 @@ set -e
 
 VERSION="1.5.0"
 VERSIONREV="63"
+PATCHSUFFIX="-p0"
 
 # The upstream tarball name is: giac"$SOURCEORIG".tar.gz
 SOURCEORIG=_"$VERSION"-"$VERSIONREV"
 
 # The name of the output file without tar.gz or tar.bz2 extension
-OUTPUTFILEBASENAME="$SAGE_DISTFILES"/giac-"$VERSION"."$VERSIONREV"
+OUTPUTFILEBASENAME="$SAGE_DISTFILES"/giac-"$VERSION"."$VERSIONREV""$PATCHSUFFIX"
 
 # Testing if the output file already exist in one of gz or bz2 format:
 if [ -f "$OUTPUTFILEBASENAME".tar.gz -o -f "$OUTPUTFILEBASENAME".tar.bz2 ] ; then
     echo >&2 "there is already a giac archive of this version"
     exit 1
 fi
 
-# Build a temporary working dir. (subdir of SAGE_DISTFILES)
-TARGET=$(mktemp -d -p"$SAGE_DISTFILES")
+# Build a temporary working dir. (preferably, a subdir of SAGE_DISTFILES)
+TARGET=$(mktemp -d -p"$SAGE_DISTFILES" || mktemp -d)
 ORIGDIR=`pwd`
 cd "$TARGET"
 
@@ -44,6 +45,9 @@ tar -xzf giac"$SOURCEORIG".tar.gz
 # rename top sourcedir
 mv giac-"$VERSION" src
 
+# remove unnecessary files
+rm -rf src/doc/pari/*.html
+
 # removing french html doc, but keep keywords, and working makefiles.
 # NB: the french html doc is huge and not GPL.
 # it is freely redistributable only for non commercial purposes.
@@ -66,9 +70,7 @@ touch html_vall
 
 # building giac source tarball for the spkg
 cd ../../../
-tar -cj src -f "$OUTPUTFILEBASENAME".tar.bz2
-
-
+tar -cjf "$OUTPUTFILEBASENAME".tar.bz2 src
 
 # cleaning extracted dir.
 cd ..