Skip to content
This repository was archived by the owner on Feb 1, 2023. It is now read-only.

Commit 98c7ce0

Browse files
author
Release Manager
committed
Trac #29532: cygwin: Fix spkg-configure.m4 for iconv
Follow-up from #27823 (spkg-configure.m4 for iconv), comment 46: It seems that, at least on Cygwin, AM_ICONV will pass, somehow, even if iconv.h is installed, thus making the libicon-devel package on Cygwin a requirement, at least when it comes to building R (which otherwise fails at #include <iconv.h>). For now I'll just update the Cygwin build instructions to require libiconv-devel as a prerequisite which is preferable anyways. But maybe this still needs to be checked for somehow... Indeed this needs fixing: {{{ configure:21635: g++ -std=gnu++11 -o conftest.exe -g -O2 conftest.cpp -lglpk -lreadline -lcurl -lbz2 -lflint -lmpfr -lgmp -lm -lntl -liconv >&5 conftest.cpp:68:10: fatal error: iconv.h: No such file or directory 68 | #include <iconv.h> | ^~~~~~~~~ compilation terminated. ... configure:21645: result: no, consider installing GNU libiconv ## ------------------------------------------------------ ## ## Checking whether SageMath should install SPKG iconv... ## ## ------------------------------------------------------ ## configure:21940: will use system package and not install SPKG iconv ## ---------------------------------------------------- ## }}} URL: https://trac.sagemath.org/29532 Reported by: mkoeppe Ticket author(s): Matthias Koeppe Reviewer(s): Dima Pasechnik
2 parents 9980a1f + 49c8e4d commit 98c7ce0

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

build/pkgs/iconv/spkg-configure.m4

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
SAGE_SPKG_CONFIGURE([iconv], [
22
AM_ICONV
3-
if test x$am_cv_func_iconv != xyes; then
3+
if test x"$am_cv_func_iconv" != xyes; then
44
sage_spkg_install_iconv=yes
55
fi
66
])

0 commit comments

Comments
 (0)