This repository was archived by the owner on Feb 1, 2023. It is now read-only.
Commit b9bd305
Trac #21884: giacpy_sage doctest failure and new libsingular cf.type == n_unknown ring test
Related to #21860 : one failure in ptestlong :
{{{
charpent@asus16-ec:/usr/local/sage-7$ sage -t --long --warn-long 100.3
src/sage/rings/polynomial/multi_polynomial_ideal.py
Running doctests with ID 2016-11-17-09-17-43-cce569e2.
Git branch: t/21860/giacblas
Using --optional=database_gap,giac,giacpy_sage,mpir,python2,sage
Doctesting 1 file.
sage -t --long --warn-long 100.3
src/sage/rings/polynomial/multi_polynomial_ideal.py
**********************************************************************
File "src/sage/rings/polynomial/multi_polynomial_ideal.py", line 3533,
in sage.rings.polynomial.multi_polynomial_ideal.NCPolynomialIdeal.groebn
er_basis
Failed example:
ideal(J.transformed_basis()).change_ring(P).interreduced_basis() #
optional - giacpy_sage
Expected:
[a - 60*c^3 + 158/7*c^2 + 8/7*c - 1, b + 30*c^3 - 79/7*c^2 + 3/7*c,
c^4 - 10/21*c^3 + 1/84*c^2 + 1/84*c]
Got:
[7*a - 420*c^3 + 158*c^2 + 8*c - 7, 7*b + 210*c^3 - 79*c^2 + 3*c,
84*c^4 - 40*c^3 + c^2 + c]
**********************************************************************
1 item had failures:
1 of 67 in sage.rings.polynomial.multi_polynomial_ideal.NCPolynomial
Ideal.groebner_basis
[723 tests, 1 failure, 9.10 s]
----------------------------------------------------------------------
sage -t --long --warn-long 100.3
src/sage/rings/polynomial/multi_polynomial_ideal.py # 1 doctest failed
----------------------------------------------------------------------
Total time for all tests: 9.2 seconds
cpu time: 15.5 seconds
cumulative wall time: 9.1 seconds
}}}
in fact it is related to the singular update #17254 where all the
{{{
if r.ringtype == 0:
}}}
were replaced by
{{{
if r.cf.type == n_unknown:
}}}
but it seems not equivalent with QQ coefficients.
Remarks: The interred_libsingular function of
multi_polynomial_ideal_libsingular.pyx
ends with an explicit:
{{{
# divide head by coeffi
...
}}}
and the groebner_basis function doc have still five examples giving:
{{{
[a - 60*c^3 + 158/7*c^2 + 8/7*c - 1, b + 30*c^3 - 79/7*c^2 + 3/7*c, c^4
- 10/21*c^3 + 1/84*c^2 + 1/84*c]
}}}
so what is the best thing for the interreduced_basis command to output?
URL: https://trac.sagemath.org/21884
Reported by: charpent
Ticket author(s): Frederic Han
Reviewer(s): Emmanuel CharpentierFile tree
2 files changed
+4
-3
lines changed- src/sage/rings/polynomial
2 files changed
+4
-3
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3530 | 3530 | | |
3531 | 3531 | | |
3532 | 3532 | | |
3533 | | - | |
| 3533 | + | |
| 3534 | + | |
3534 | 3535 | | |
3535 | 3536 | | |
3536 | 3537 | | |
| |||
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
280 | 280 | | |
281 | 281 | | |
282 | 282 | | |
283 | | - | |
| 283 | + | |
284 | 284 | | |
285 | 285 | | |
286 | 286 | | |
| |||
310 | 310 | | |
311 | 311 | | |
312 | 312 | | |
313 | | - | |
| 313 | + | |
314 | 314 | | |
315 | 315 | | |
316 | 316 | | |
| |||
0 commit comments