Skip to content
This repository was archived by the owner on Feb 1, 2023. It is now read-only.

Commit c53ddc7

Browse files
author
Matthias Koeppe
committed
Use 'failures', not 'error' when reporting testsuite failures
1 parent ca36a87 commit c53ddc7

File tree

2 files changed

+3
-6
lines changed

2 files changed

+3
-6
lines changed

build/bin/sage-spkg

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1037,7 +1037,7 @@ if [ "$SAGE_CHECK" = "yes" -o "$SAGE_CHECK" = "warn" ]; then
10371037
if [ $? -ne 0 ]; then
10381038
TEST_SUITE_RESULT="failed"
10391039
if [ "$SAGE_CHECK" = "warn" ]; then
1040-
error_msg "Warning: Error testing package $PKG_NAME (ignored)" "make check"
1040+
error_msg "Warning: Failures testing package $PKG_NAME (ignored)" "make check"
10411041
else
10421042
error_msg "Error testing package $PKG_NAME" "make check"
10431043
exit 1

build/pkgs/openblas/spkg-check.in

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -21,16 +21,13 @@ ${MAKE:-make} tests $OPENBLAS_CONFIGURE
2121
if [ $? -ne 0 ]; then
2222
# First make sure we already didn't set a target
2323
if [[ $OPENBLAS_CONFIGURE == *"TARGET"* ]]; then
24-
sdh_die "Error while running the OpenBLAS testsuite ... exiting"
24+
sdh_die "Failures while running the OpenBLAS testsuite ... exiting"
2525
else
2626
# The recommended TARGET is ATOM if CPU fails
2727
# See https://github.com/xianyi/OpenBLAS/issues/1204
2828
OPENBLAS_CONFIGURE="$OPENBLAS_CONFIGURE TARGET=ATOM"
29-
echo "Error while testing the OpenBLAS testsuite"
29+
echo "Failures while testing the OpenBLAS testsuite"
3030
echo "Retrying the OpenBLAS testsuite with TARGET=ATOM"
3131
${MAKE:-make} tests $OPENBLAS_CONFIGURE
32-
if [ $? -ne 0 ]; then
33-
sdh_die "Error while running the OpenBLAS testsuite ... exiting"
34-
fi
3532
fi
3633
fi

0 commit comments

Comments
 (0)