Skip to content
This repository was archived by the owner on Feb 1, 2023. It is now read-only.

Commit d208f8c

Browse files
committed
Trac #29489: clean up conftest.dir and conftest_venv after use.
The python3 spkg-configure.m4 creates two temporary directories called conftest.dir and conftest_venv, but fails to clean them up. This would normally be harmless, except that several other autoconf macros try to "rm -f conftest*", which spits out a warning when it encounters a directory. Since we can't fix the macros that we didn't write, this commit modifies the post-check phase of the python3 SAGE_SPKG_CONFIGURE to clean up its own mess.
1 parent 10ed24e commit d208f8c

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

build/pkgs/python3/spkg-configure.m4

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -93,4 +93,10 @@ EOF
9393
dnl POST
9494
AS_IF([test x$sage_spkg_install_python3 = xno], [PYTHON_FOR_VENV="$ac_cv_path_PYTHON3"])
9595
AC_SUBST([PYTHON_FOR_VENV])
96+
97+
dnl These temporary directories are created by the check above
98+
dnl and need to be cleaned up to prevent the "rm -f conftest*"
99+
dnl (that a bunch of other checks do) from emitting warnings about
100+
dnl conftest.dir and conftest_venv being directories.
101+
rm -rf conftest.dir conftest_venv
96102
])

0 commit comments

Comments
 (0)