Trac #30687: "make python3-clean" should always remove local/bin/python3*

Release Manager · Release Manager · commit dc3fc00492fe · 2020-10-16T23:34:27.000+02:00
`make python3-clean` does not remove `$SAGE_LOCAL/bin/python3*` - certainly not if an external `python3` is used. We do the uninstallation in an `spkg-legacy-uninstall` script. (We also repair the `spkg-legacy-uninstall` mechanism - it was broken in #29096.) Critical for Sage 9.2 because it will help avoid puzzling incremental build behavior, which could include corruption of the installed system python if that is writable for the user. URL: https://trac.sagemath.org/30687 Reported by: dimpase Ticket author(s): Matthias Koeppe Reviewer(s): John Palmieri
diff --git a/build/bin/sage-spkg b/build/bin/sage-spkg
@@ -525,7 +525,7 @@ __EOF__
 }
 
 
-WRAPPED_SCRIPTS="build install check preinst postinst legacy-uninstall prerm postrm"
+WRAPPED_SCRIPTS="build install check preinst postinst prerm postrm"
 INSTALLED_SCRIPTS="prerm postrm"
 
 
diff --git a/build/pkgs/boost_cropped/spkg-legacy-uninstall b/build/pkgs/boost_cropped/spkg-legacy-uninstall
@@ -1 +1,2 @@
+#! /usr/bin/env bash
 rm -rf "${SAGE_LOCAL}"/include/boost
diff --git a/build/pkgs/brial/spkg-legacy-uninstall b/build/pkgs/brial/spkg-legacy-uninstall
@@ -1,3 +1,4 @@
+#! /usr/bin/env bash
 echo "Cleaning out old PolyBoRi and BRiAl installations"
 rm -f "$SAGE_LOCAL"/lib/lib{polybori,brial}*
 rm -rf "$SAGE_LOCAL"/include/polybori*
diff --git a/build/pkgs/cunningham_tables/spkg-legacy-uninstall b/build/pkgs/cunningham_tables/spkg-legacy-uninstall
@@ -1 +1,2 @@
+#! /usr/bin/env bash
 rm -rf $SAGE_SHARE/cunningham_tables
diff --git a/build/pkgs/ecl/spkg-legacy-uninstall b/build/pkgs/ecl/spkg-legacy-uninstall
@@ -1,3 +1,4 @@
+#! /usr/bin/env bash
 rm -f "$SAGE_LOCAL"/bin/ecl
 rm -rf "$SAGE_LOCAL"/include/ecl
 rm -rf "$SAGE_LOCAL"/lib/ecl
diff --git a/build/pkgs/gap/spkg-legacy-uninstall b/build/pkgs/gap/spkg-legacy-uninstall
@@ -1,3 +1,4 @@
+#! /usr/bin/env bash
 # Remove existing GAP 4.x install(s)
 rm -rf "$SAGE_LOCAL/gap/gap-4."*
 rm -rf "$SAGE_SHARE/gap"
diff --git a/build/pkgs/gfan/spkg-legacy-uninstall b/build/pkgs/gfan/spkg-legacy-uninstall
@@ -1,2 +1,3 @@
+#! /usr/bin/env bash
 echo "Removing old version of gfan (if any)..."
 rm -f "$SAGE_LOCAL"/bin/gfan*
diff --git a/build/pkgs/gsl/spkg-legacy-uninstall b/build/pkgs/gsl/spkg-legacy-uninstall
@@ -1,2 +1,3 @@
+#! /usr/bin/env bash
 rm -rf "$SAGE_LOCAL"/include/gsl
 rm -rf "$SAGE_LOCAL"/lib/libgsl*
diff --git a/build/pkgs/jmol/spkg-legacy-uninstall b/build/pkgs/jmol/spkg-legacy-uninstall
@@ -1,3 +1,4 @@
+#! /usr/bin/env bash
 # Cleanup of previous installation
 rm -rf "${SAGE_SHARE}/jsmol/"
 rm -rf "${SAGE_SHARE}/jmol/"
diff --git a/build/pkgs/lcalc/spkg-legacy-uninstall b/build/pkgs/lcalc/spkg-legacy-uninstall
@@ -1 +1,2 @@
+#! /usr/bin/env bash
 rm -fr "$SAGE_LOCAL"/include/libLfunction
diff --git a/build/pkgs/libgd/spkg-legacy-uninstall b/build/pkgs/libgd/spkg-legacy-uninstall
@@ -1,3 +1,4 @@
+#! /usr/bin/env bash
 # Critical to get rid of old versions, since they will break the install, since
 # at some point one of the libraries accidently links against what's in SAGE_LOCAL,
 # instead of what is in the build directory!
diff --git a/build/pkgs/mpfrcx/spkg-legacy-uninstall b/build/pkgs/mpfrcx/spkg-legacy-uninstall
@@ -1,3 +1,4 @@
+#! /usr/bin/env bash
 echo "Deleting old headers"
 rm -f "$SAGE_LOCAL"/include/mpfrcx.h
 rm -f "$SAGE_LOCAL"/lib/libmpfrcx.*
diff --git a/build/pkgs/numpy/spkg-legacy-uninstall b/build/pkgs/numpy/spkg-legacy-uninstall
@@ -1 +1,2 @@
+#! /usr/bin/env bash
 rm -rf "$SAGE_LOCAL"/lib/python*/site-packages/numpy
diff --git a/build/pkgs/polymake/spkg-legacy-uninstall b/build/pkgs/polymake/spkg-legacy-uninstall
@@ -1 +1,2 @@
+#! /usr/bin/env bash
 rm -rf "$SAGE_LOCAL"/include/polymake "$SAGE_LOCAL"/lib/libpolymake* "$SAGE_LOCAL"/lib/polymake "$SAGE_LOCAL"/share/polymake "$SAGE_LOCAL"/bin/polymake*
diff --git a/build/pkgs/polytopes_db_4d/spkg-legacy-uninstall b/build/pkgs/polytopes_db_4d/spkg-legacy-uninstall
@@ -1,2 +1,3 @@
+#! /usr/bin/env bash
 # Cleanup of previous installation
 rm -rf "${SAGE_SHARE}/reflexive_polytopes/Hodge4d"
diff --git a/build/pkgs/python3/spkg-legacy-uninstall b/build/pkgs/python3/spkg-legacy-uninstall
@@ -0,0 +1,4 @@
+#! /usr/bin/env bash
+echo "Cleaning out old python / python3 / python3 venv binaries"
+rm -f "$SAGE_LOCAL"/pyvenv.cfg
+rm -f "$SAGE_LOCAL"/bin/python "$SAGE_LOCAL"/bin/python3 "$SAGE_LOCAL"/bin/python3.*
diff --git a/build/pkgs/r/spkg-legacy-uninstall b/build/pkgs/r/spkg-legacy-uninstall
@@ -1,3 +1,4 @@
+#! /usr/bin/env bash
 # Remove old install
 rm -rf "$SAGE_LOCAL"/lib/r
 rm -rf "$SAGE_LOCAL"/lib/R
diff --git a/build/sage_bootstrap/uninstall.py b/build/sage_bootstrap/uninstall.py
@@ -134,7 +134,7 @@ def legacy_uninstall(spkg_name, verbose=False):
 
     # Any errors from this, including a non-zero return code will
     # bubble up and exit the uninstaller
-    subprocess.check_call(['bash', legacy_uninstall])
+    subprocess.check_call([legacy_uninstall])
 
 
 def modern_uninstall(spkg_name, sage_local, files, verbose=False):

Original file line number	Diff line number	Diff line change
`@@ -525,7 +525,7 @@ __EOF__`
`525`	`525`	`}`
`526`	`526`
`527`	`527`
`528`		`-WRAPPED_SCRIPTS="build install check preinst postinst legacy-uninstall prerm postrm"`
	`528`	`+WRAPPED_SCRIPTS="build install check preinst postinst prerm postrm"`
`529`	`529`	`INSTALLED_SCRIPTS="prerm postrm"`
`530`	`530`
`531`	`531`
Original file line number	Diff line number	Diff line change
`@@ -1 +1,2 @@`
	`1`	`+#! /usr/bin/env bash`
`1`	`2`	`rm -rf "${SAGE_LOCAL}"/include/boost`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,4 @@`
	`1`	`+#! /usr/bin/env bash`
`1`	`2`	`echo "Cleaning out old PolyBoRi and BRiAl installations"`
`2`	`3`	`rm -f "$SAGE_LOCAL"/lib/lib{polybori,brial}*`
`3`	`4`	`rm -rf "$SAGE_LOCAL"/include/polybori*`
Original file line number	Diff line number	Diff line change
`@@ -1 +1,2 @@`
	`1`	`+#! /usr/bin/env bash`
`1`	`2`	`rm -rf $SAGE_SHARE/cunningham_tables`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,4 @@`
	`1`	`+#! /usr/bin/env bash`
`1`	`2`	`rm -f "$SAGE_LOCAL"/bin/ecl`
`2`	`3`	`rm -rf "$SAGE_LOCAL"/include/ecl`
`3`	`4`	`rm -rf "$SAGE_LOCAL"/lib/ecl`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,4 @@`
	`1`	`+#! /usr/bin/env bash`
`1`	`2`	`# Remove existing GAP 4.x install(s)`
`2`	`3`	`rm -rf "$SAGE_LOCAL/gap/gap-4."*`
`3`	`4`	`rm -rf "$SAGE_SHARE/gap"`
Original file line number	Diff line number	Diff line change
`@@ -1,2 +1,3 @@`
	`1`	`+#! /usr/bin/env bash`
`1`	`2`	`echo "Removing old version of gfan (if any)..."`
`2`	`3`	`rm -f "$SAGE_LOCAL"/bin/gfan*`
Original file line number	Diff line number	Diff line change
`@@ -1,2 +1,3 @@`
	`1`	`+#! /usr/bin/env bash`
`1`	`2`	`rm -rf "$SAGE_LOCAL"/include/gsl`
`2`	`3`	`rm -rf "$SAGE_LOCAL"/lib/libgsl*`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,4 @@`
	`1`	`+#! /usr/bin/env bash`
`1`	`2`	`# Cleanup of previous installation`
`2`	`3`	`rm -rf "${SAGE_SHARE}/jsmol/"`
`3`	`4`	`rm -rf "${SAGE_SHARE}/jmol/"`
Original file line number	Diff line number	Diff line change
`@@ -1 +1,2 @@`
	`1`	`+#! /usr/bin/env bash`
`1`	`2`	`rm -fr "$SAGE_LOCAL"/include/libLfunction`