Trac #31143: shorten range(0, *) in combinat folder

URL: https://trac.sagemath.org/31143
Reported by: chapoton
Ticket author(s): Frédéric Chapoton
Reviewer(s): David Coudert

Author: Release Manager

src/sage/combinat/cartesian_product.py

@@ -98,7 +98,7 @@ def __init__(self, *iters):
         category = EnumeratedSets()
         try:
             category = category.Finite() if self.is_finite() else category.Infinite()
-        except ValueError: # Unable to determine if it is finite or not
+        except ValueError:  # Unable to determine if it is finite or not
             pass
 
         def iterfunc():
@@ -141,7 +141,7 @@ def __reduce__(self):
 
         TESTS::
 
-            sage: cp = cartesian_product([[1,2],range(0,9)])
+            sage: cp = cartesian_product([[1,2],range(9)])
             sage: loads(dumps(cp)) == cp
             True
         """

src/sage/combinat/finite_state_machine_generators.py

@@ -149,7 +149,6 @@ def AnyLetter(self, input_alphabet):
                          initial_states=[z],
                          final_states=[o])
 
-
     def AnyWord(self, input_alphabet):
         r"""
         Return an automaton recognizing any word of the given
@@ -1026,7 +1025,7 @@ def GrayCode(self):
             sage: G = transducers.GrayCode()
             sage: G
             Transducer with 3 states
-            sage: for v in srange(0, 10):
+            sage: for v in srange(10):
             ....:     print("{} {}".format(v, G(v.digits(base=2))))
             0 []
             1 [1]

src/sage/combinat/fully_packed_loop.py

@@ -301,7 +301,7 @@ class FullyPackedLoop(Element, metaclass=InheritComparisonClasscallMetaclass):
         sage: ncp = FullyPackedLoop(ASMs[1]).link_pattern() # fpl's gyration orbit size is 2
         sage: rotated_ncp=[]
         sage: for (a,b) in ncp:
-        ....:     for i in range(0,5):
+        ....:     for i in range(5):
         ....:         a,b=a%6+1,b%6+1;
         ....:     rotated_ncp.append((a,b))
         sage: PerfectMatching(ASMs[1].gyration().to_fully_packed_loop().link_pattern()) ==\
@@ -312,7 +312,7 @@ class FullyPackedLoop(Element, metaclass=InheritComparisonClasscallMetaclass):
         sage: ncp = fpl.link_pattern() # fpl's gyration size is 3
         sage: rotated_ncp=[]
         sage: for (a,b) in ncp:
-        ....:     for i in range(0,5):
+        ....:     for i in range(5):
         ....:         a,b=a%6+1,b%6+1;
         ....:     rotated_ncp.append((a,b))
         sage: PerfectMatching(ASMs[0].gyration().to_fully_packed_loop().link_pattern()) ==\
@@ -325,7 +325,7 @@ class FullyPackedLoop(Element, metaclass=InheritComparisonClasscallMetaclass):
         sage: ncp = fpl.link_pattern()
         sage: rotated_ncp=[]
         sage: for (a,b) in ncp:
-        ....:     for i in range(0,13):
+        ....:     for i in range(13):
         ....:         a,b=a%14+1,b%14+1;
         ....:     rotated_ncp.append((a,b))
         sage: PerfectMatching(mat.gyration().to_fully_packed_loop().link_pattern()) ==\
@@ -338,7 +338,7 @@ class FullyPackedLoop(Element, metaclass=InheritComparisonClasscallMetaclass):
         sage: ncp = fpl.link_pattern()
         sage: rotated_ncp=[]
         sage: for (a,b) in ncp:
-        ....:     for i in range(0,11):
+        ....:     for i in range(11):
         ....:         a,b=a%12+1,b%12+1;
         ....:     rotated_ncp.append((a,b))
         sage: PerfectMatching(mat.gyration().to_fully_packed_loop().link_pattern()) ==\
@@ -1086,7 +1086,7 @@ def link_pattern(self):
             sage: ncp = FullyPackedLoop(ASMs[1]).link_pattern()
             sage: rotated_ncp=[]
             sage: for (a,b) in ncp:
-            ....:     for i in range(0,5):
+            ....:     for i in range(5):
             ....:         a,b=a%6+1,b%6+1;
             ....:     rotated_ncp.append((a,b))
             sage: PerfectMatching(ASMs[1].gyration().to_fully_packed_loop().link_pattern()) ==\
@@ -1097,7 +1097,7 @@ def link_pattern(self):
             sage: ncp = fpl.link_pattern()
             sage: rotated_ncp=[]
             sage: for (a,b) in ncp:
-            ....:     for i in range(0,5):
+            ....:     for i in range(5):
             ....:         a,b=a%6+1,b%6+1;
             ....:     rotated_ncp.append((a,b))
             sage: PerfectMatching(ASMs[0].gyration().to_fully_packed_loop().link_pattern()) ==\
@@ -1110,7 +1110,7 @@ def link_pattern(self):
             sage: ncp = fpl.link_pattern()
             sage: rotated_ncp=[]
             sage: for (a,b) in ncp:
-            ....:     for i in range(0,13):
+            ....:     for i in range(13):
             ....:         a,b=a%14+1,b%14+1;
             ....:     rotated_ncp.append((a,b))
             sage: PerfectMatching(mat.gyration().to_fully_packed_loop().link_pattern()) ==\
@@ -1123,7 +1123,7 @@ def link_pattern(self):
             sage: ncp = fpl.link_pattern()
             sage: rotated_ncp=[]
             sage: for (a,b) in ncp:
-            ....:     for i in range(0,11):
+            ....:     for i in range(11):
             ....:         a,b=a%12+1,b%12+1;
             ....:     rotated_ncp.append((a,b))
             sage: PerfectMatching(mat.gyration().to_fully_packed_loop().link_pattern()) ==\
@@ -1367,7 +1367,7 @@ def _element_constructor_(self, generator):
         elif isinstance(generator, SquareIceModel.Element) or \
         isinstance(generator, SixVertexConfiguration):
             SVM = generator
-        else: # Not ASM nor SVM
+        else:  # Not ASM nor SVM
             try:
                 SVM = AlternatingSignMatrix(generator).to_six_vertex_model()
             except (TypeError, ValueError):
@@ -1404,7 +1404,7 @@ def cardinality(self):
 
         EXAMPLES::
 
-            sage: [AlternatingSignMatrices(n).cardinality() for n in range(0, 11)]
+            sage: [AlternatingSignMatrices(n).cardinality() for n in range(11)]
             [1, 1, 2, 7, 42, 429, 7436, 218348, 10850216, 911835460, 129534272700]
         """
         return Integer(prod( [ factorial(3*k+1)/factorial(self._n+k)

src/sage/combinat/gelfand_tsetlin_patterns.py

@@ -1170,7 +1170,7 @@ def random_element(self):
             True
             sage: len(x)
             4
-            sage: all(y in range(0, 5+1) for z in x for y in z)
+            sage: all(y in range(5+1) for z in x for y in z)
             True
             sage: x.check()
 
@@ -1182,7 +1182,7 @@ def random_element(self):
             True
             sage: len(x)
             4
-            sage: all(y in range(0, 5+1) for z in x for y in z)
+            sage: all(y in range(5+1) for z in x for y in z)
             True
             sage: x.check()
             sage: x.is_strict()

src/sage/combinat/partition.py

@@ -5054,7 +5054,7 @@ def dimension(self, smaller = [], k = 1):
         Checks that the dimension satisfies the obvious recursion relation::
 
             sage: test = lambda larger, smaller: larger.dimension(smaller) == sum(mu.dimension(smaller) for mu in larger.down())
-            sage: all(test(larger,smaller) for l in range(1,10) for s in range(0,10)
+            sage: all(test(larger,smaller) for l in range(1,10) for s in range(10)
             ....:     for larger in Partitions(l) for smaller in Partitions(s) if smaller != larger)
             True
 
@@ -7434,8 +7434,8 @@ def list(self):
         if h == 0:
             return [self.element_class(self, [])]
         else:
-            l = [[i] for i in range(0, w+1)]
-            add = lambda x: [ x+[i] for i in range(0, x[-1]+1)]
+            l = [[i] for i in range(w + 1)]
+            add = lambda x: [x + [i] for i in range(x[-1] + 1)]
             for i in range(h-1):
                 new_list = []
                 for element in l:

src/sage/combinat/permutation.py

@@ -223,15 +223,15 @@
 ===================
 """
 
-#*****************************************************************************
+# ****************************************************************************
 #       Copyright (C) 2007 Mike Hansen <[email protected]>
 #
 # This program is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by
 # the Free Software Foundation, either version 2 of the License, or
 # (at your option) any later version.
 #                  https://www.gnu.org/licenses/
-#*****************************************************************************
+# ****************************************************************************
 
 from sage.structure.parent import Parent
 from sage.structure.unique_representation import UniqueRepresentation
@@ -701,7 +701,7 @@ def size(self):
 
     def cycle_string(self, singletons=False):
         """
-        Returns a string of the permutation in cycle notation.
+        Return a string of the permutation in cycle notation.
 
         If ``singletons=True``, it includes 1-cycles in the string.
 
@@ -749,8 +749,8 @@ def __next__(self):
 
         #Starting from the end, find the first o such that
         #p[o] < p[o+1]
-        for i in reversed(range(0,n-1)):
-            if p[i] < p[i+1]:
+        for i in reversed(range(n - 1)):
+            if p[i] < p[i + 1]:
                 first = i
                 break
 
@@ -809,8 +809,8 @@ def prev(self):
 
         #Starting from the end, find the first o such that
         #p[o] > p[o+1]
-        for i in reversed(range(0, n-1)):
-            if p[i] > p[i+1]:
+        for i in reversed(range(n - 1)):
+            if p[i] > p[i + 1]:
                 first = i
                 break
 
@@ -968,7 +968,7 @@ def to_cycles(self, singletons=True, use_min=True):
 
     def _to_cycles_orig(self, singletons=True):
         r"""
-        Returns the permutation ``self`` as a list of disjoint cycles.
+        Return the permutation ``self`` as a list of disjoint cycles.
 
         EXAMPLES::
 
@@ -1115,7 +1115,7 @@ def _to_cycles_list(self, singletons=True):
 
     def to_permutation_group_element(self):
         """
-        Returns a PermutationGroupElement equal to self.
+        Return a PermutationGroupElement equal to self.
 
         EXAMPLES::
 
@@ -1389,15 +1389,9 @@ def rank(self):
             True
         """
         n = len(self)
-
         factoradic = self.to_lehmer_code()
-
-        #Compute the index
-        rank = 0
-        for i in reversed(range(0, n)):
-            rank += factoradic[n-1-i]*factorial(i)
-
-        return rank
+        return sum(factoradic[n - 1 - i] * factorial(i)
+                   for i in reversed(range(n)))
 
     ##############
     # Inversions #
@@ -1869,10 +1863,10 @@ def _icondition(self, i):
 
         .. NOTE::
 
-           An imove (that is, an iswitch or an ishift) can only be applied
-           when the relative positions of `i-1,i,i+1` are one of '213',
-           '132', '231', or '312'. ``None`` is returned in the other cases
-           to signal that an imove cannot be applied.
+            An imove (that is, an iswitch or an ishift) can only be applied
+            when the relative positions of `i-1,i,i+1` are one of '213',
+            '132', '231', or '312'. ``None`` is returned in the other cases
+            to signal that an imove cannot be applied.
 
         EXAMPLES::
 
@@ -2161,9 +2155,9 @@ def longest_increasing_subsequences(self):
         r"""
         Return the list of the longest increasing subsequences of ``self``.
 
-        .. note::
+        .. NOTE::
 
-           The algorithm is not optimal.
+            The algorithm is not optimal.
 
         EXAMPLES::
 
@@ -2704,7 +2698,7 @@ def to_lehmer_cocode(self):
         n = len(p)
         cocode = [0] * n
         for i in range(1, n):
-            for j in range(0, i):
+            for j in range(i):
                 if p[j] > p[i]:
                     cocode[i] += 1
         return cocode
@@ -3652,7 +3646,7 @@ def bruhat_smaller(self):
 
     def bruhat_greater(self):
         r"""
-        Returns the combinatorial class of permutations greater than or
+        Return the combinatorial class of permutations greater than or
         equal to ``self`` in the Bruhat order (on the symmetric group
         containing ``self``).
 
@@ -3799,7 +3793,7 @@ def permutohedron_succ(self, side="right"):
         P = Permutations()
         succ = []
         if side == "right":
-            rise = lambda perm: [i for i in range(0,n-1) if perm[i] < perm[i+1]]
+            rise = lambda perm: [i for i in range(n - 1) if perm[i] < perm[i+1]]
             for i in rise(p):
                 pp = p[:]
                 pp[i] = p[i+1]
@@ -4313,7 +4307,7 @@ def simion_schmidt(self, avoid=[1,2,3]):
     @combinatorial_map(order=2,name='reverse')
     def reverse(self):
         """
-        Returns the permutation obtained by reversing the list.
+        Return the permutation obtained by reversing the list.
 
         EXAMPLES::
 
@@ -4379,7 +4373,7 @@ def permutation_poset(self):
 
     def dict(self):
         """
-        Returns a dictionary corresponding to the permutation.
+        Return a dictionary corresponding to the permutation.
 
         EXAMPLES::
 

src/sage/combinat/plane_partition.py

@@ -583,12 +583,12 @@ def is_SPP(self):
         c1 = len(Z)
         c2 = len(Z[0])
         size = max(c1, c2)
-        T = [[0 for i in range(0,size)] for j in range(0,size)]
-        for i in range(0,c1):
-            for j in range(0,c2):
-                T[i][j]=Z[i][j]
+        T = [[0 for i in range(size)] for j in range(size)]
+        for i in range(c1):
+            for j in range(c2):
+                T[i][j] = Z[i][j]
         return all(T[r][c] == T[c][r]
-            for r in range(0,size)
+            for r in range(size)
             for c in range(r, size))
 
     def is_CSPP(self):

src/sage/combinat/rigged_configurations/bij_type_B.py

@@ -817,7 +817,7 @@ def next_state(self, height):
                 end = ell[a]
                 if a < height:
                     end = len(self.cur_partitions[a])
-                for i in reversed(range(0, end)):
+                for i in reversed(range(end)):
                     if self.cur_partitions[a][i] >= last_size and \
                       self.cur_partitions[a].vacancy_numbers[i] == self.cur_partitions[a].rigging[i]:
                         ell[n + a] = i

src/sage/combinat/rigged_configurations/bij_type_D.py

@@ -616,7 +616,7 @@ def next_state(self, height):
                 end = ell[a]
                 if a < height:
                     end = len(self.cur_partitions[a])
-                for i in reversed(range(0, end)):
+                for i in reversed(range(end)):
                     if self.cur_partitions[a][i] >= last_size and \
                       self.cur_partitions[a].vacancy_numbers[i] == self.cur_partitions[a].rigging[i]:
                         ell[n + a] = i

src/sage/combinat/root_system/root_lattice_realization_algebras.py

@@ -202,7 +202,7 @@ def isobaric_divided_difference_on_basis(self, weight, i):
                 raise ValueError("the weight does not have an integral scalar product with the coroot")
             alphai = P.simple_root(i)
             if n >= 0:
-                return  self.sum_of_monomials(weight-j*alphai for j in range(0,n+1))
+                return  self.sum_of_monomials(weight-j*alphai for j in range(n + 1))
             else:
                 return -self.sum_of_monomials(weight-j*alphai for j in range(n+1,0))