Skip to content

Commit 7e32815

Browse files
committed
Reorganized a bit and added comments about what will eventually disappear.
1 parent d02af89 commit 7e32815

File tree

1 file changed

+13
-12
lines changed

1 file changed

+13
-12
lines changed

Dockerfile

Lines changed: 13 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -2,20 +2,21 @@ FROM sagemath/sagemath:8.0
22

33
# Inspired from https://mybinder.readthedocs.io/en/latest/dockerfile.html#preparing-your-dockerfile
44

5-
ENV NB_USER sage
6-
ENV HOME /home/${NB_USER}
5+
ENV NB_USER=sage
6+
ENV HOME /home/sage
77

8-
# Make sure the contents of our repo are in ${HOME}
9-
COPY . ${HOME}
10-
USER root
11-
COPY jupyter jupyter-notebook /usr/bin/
12-
RUN chown -R ${NB_USER}:${NB_USER} ${HOME}
13-
USER ${NB_USER}
14-
15-
# Upgrade to jupyter 5.* as required by mybinder
8+
# Upgrade to jupyter 5.* as required by mybinder and install additional kernels
9+
# This will eventually be lifted upstream to sagemath/sagemath
1610
RUN sage -pip install "notebook>=5" "ipykernel>=4.6"
17-
18-
# Install additional kernels
1911
RUN sage -i gap_jupyter
2012
RUN sage -i singular_jupyter
2113
RUN sage -i pari_jupyter
14+
15+
USER root
16+
# This will eventually be lifted upstream to sagemath/sagemath
17+
COPY jupyter jupyter-notebook /usr/bin/
18+
19+
# Make sure the contents of our repo are in ${HOME}
20+
COPY . ${HOME}
21+
RUN chown -R ${NB_USER}:${NB_USER} ${HOME}
22+
USER ${NB_USER}

0 commit comments

Comments
 (0)