Skip to content

Commit dcd47e4

Browse files
author
Zerline
committed
For an empty partition.
1 parent 93c58fa commit dcd47e4

File tree

2 files changed

+11
-2
lines changed

2 files changed

+11
-2
lines changed

sage_combinat_widgets/grid_view_editor.py

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -228,7 +228,7 @@ def compute(self, obj=None):
228228
"""
229229
if not obj:
230230
obj = self.value
231-
if not obj:
231+
if obj is None:
232232
return
233233
self.cells = self.adapter.compute_cells(obj)
234234
celltype = self.adapter.celltype
@@ -290,7 +290,10 @@ def compute_height(self):
290290
"""
291291
if not hasattr(self, 'cells'):
292292
self.compute()
293-
maxpos = max(pos[0] for pos in self.cells)
293+
if self.cells:
294+
maxpos = max(pos[0] for pos in self.cells)
295+
else:
296+
maxpos = -1
294297
self.height = maxpos + 1 # Number of rows in self.value
295298
for pos in self.addable_cells():
296299
if pos[0] > maxpos:
@@ -709,6 +712,11 @@ def remove_cell(self, change):
709712
sage: e.remove_cell(Bunch({'name': 'cell_0_4', 'old': 3, 'new': 0, 'owner': e, 'type': 'change'}))
710713
sage: e.value
711714
[[None, None, 1, 2], [None, 1], [4]]
715+
sage: p = Partition([1])
716+
sage: e = GridViewEditor(p)
717+
sage: e.remove_cell(Bunch({'name': 'cell_0_0', 'old': False, 'new': True, 'owner': e, 'type': 'change'}))
718+
sage: e.value
719+
[]
712720
"""
713721
# Do nothing at widget donottrack and do not track widget value
714722
if self.donottrack or change.name == 'value':

sage_combinat_widgets/grid_view_widget.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -504,6 +504,7 @@ def draw(self, cell_widget_classes=None, cell_widget_class_index=None,
504504
addable_widget_class = self.addable_widget_class
505505
if not blank_widget_class:
506506
blank_widget_class = self.blank_widget_class
507+
i, j = -1, -1 # initialization ; necessary for an empty grid
507508
for i in range(self.height):
508509
r = rows[i]
509510
if not r: # Empty row

0 commit comments

Comments
 (0)