removce some deprecated aliases in abelian groups

Author: fchapoton

src/sage/groups/additive_abelian/additive_abelian_wrapper.py

@@ -74,8 +74,6 @@
 from sage.structure.sequence import Sequence
 from sage.modules.free_module_element import vector
 
-from sage.misc.superseded import deprecated_function_alias
-
 
 class UnwrappingMorphism(Morphism):
     r"""
@@ -324,8 +322,6 @@ def discrete_exp(self, v):
         # DUMB IMPLEMENTATION!
         return sum([self._gen_elements[i] * ZZ(v[i]) for i in range(len(v))], self.universe()(0))
 
-    _discrete_exp = deprecated_function_alias(32384, discrete_exp)
-
     def discrete_log(self, x, gens=None):
         r"""
         Given an element of the ambient group, attempt to express it in terms
@@ -421,8 +417,6 @@ def discrete_log(self, x, gens=None):
         assert x == sum(r * g for r, g in zip(res, gens))
         return res
 
-    _discrete_log = deprecated_function_alias(32384, discrete_log)
-
     def torsion_subgroup(self, n=None):
         r"""
         Return the `n`-torsion subgroup of this additive abelian group
@@ -594,7 +588,7 @@ def _base(j, k, c):
 
         assert k - j == 1
         aajk = subbasis(j, k)
-        assert not any(p*a for a in aajk)  # orders are in {1,p}
+        assert not any(p * a for a in aajk)  # orders are in {1,p}
         idxs = [i for i, a in enumerate(aajk) if a]
 
         rs = [([0], [0]) for i in range(len(aajk))]
@@ -627,18 +621,18 @@ def _rec(j, k, c):
             return _base(j, k, c)
 
         w = 2
-        js = list(range(j, k, (k-j+w-1) // w)) + [k]
+        js = list(range(j, k, (k - j + w - 1) // w)) + [k]
         assert len(js) == w + 1
 
         x = vector([0] * len(aa))
         for i in reversed(range(w)):
 
             gamma = p ** (js[i] - j) * c - dotprod(x, subbasis(js[i], k))
 
-            v = _rec(js[i], js[i+1], gamma)
+            v = _rec(js[i], js[i + 1], gamma)
 
-            assert not any(q1 % q2 for q1, q2 in zip(qq(js[i], js[i+1]), qq(js[i], k)))
-            x += vector(q1 // q2 * r for q1, q2, r in zip(qq(js[i], js[i+1]), qq(js[i], k), v))
+            assert not any(q1 % q2 for q1, q2 in zip(qq(js[i], js[i + 1]), qq(js[i], k)))
+            x += vector(q1 // q2 * r for q1, q2, r in zip(qq(js[i], js[i + 1]), qq(js[i], k), v))
 
         return x
 
@@ -700,7 +694,7 @@ def _expand_basis_pgroup(p, alphas, vals, beta, h, rel):
 
     # step 1
     min_r = rel[-1] or float('inf')
-    for i in range(k-1):
+    for i in range(k - 1):
         if not rel[i]:
             continue
         if rel[i] < 0:
@@ -712,16 +706,16 @@ def _expand_basis_pgroup(p, alphas, vals, beta, h, rel):
     if min_r == float('inf'):
         raise ValueError('rel must have at least one nonzero entry')
     val_rlast = rel[-1].valuation(p)
-#    assert rel[-1] == p ** val_rlast
-#    assert not sum(r*a for r,a in zip(rel, alphas+[beta]))
+    #    assert rel[-1] == p ** val_rlast
+    #    assert not sum(r*a for r,a in zip(rel, alphas+[beta]))
 
     # step 2
     if rel[-1] == min_r:
-        for i in range(k-1):
-            beta += alphas[i] * (rel[i]//rel[-1])
+        for i in range(k - 1):
+            beta += alphas[i] * (rel[i] // rel[-1])
         alphas.append(beta)
         vals.append(val_rlast)
-#        assert alphas[-1].order() == p**vals[-1]
+        #        assert alphas[-1].order() == p**vals[-1]
         return
 
     # step 3