Skip to content

Commit 06058b3

Browse files
committed
fix issue 40885: restore correct setting of attribute
1 parent f4adc25 commit 06058b3

File tree

1 file changed

+14
-1
lines changed

1 file changed

+14
-1
lines changed

src/sage/graphs/generic_graph.py

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6941,6 +6941,15 @@ def faces(self, embedding=None):
69416941

69426942
sage: graphs.PathGraph(3).faces()
69436943
[[(0, 1), (1, 2), (2, 1), (1, 0)]]
6944+
6945+
Check that :issue:`40885` is fixed::
6946+
6947+
sage: g = graphs.CycleGraph(3)
6948+
sage: hasattr(g, '_embedding')
6949+
False
6950+
sage: F = g.faces()
6951+
sage: hasattr(g, '_embedding')
6952+
False
69446953
"""
69456954
if not self.order() or not self.size():
69466955
return []
@@ -6951,9 +6960,13 @@ def faces(self, embedding=None):
69516960
else:
69526961
embedding = self.get_embedding()
69536962
if embedding is None:
6963+
has_attribute = hasattr(self, '_embedding')
69546964
if self.is_planar(set_embedding=True):
69556965
embedding = self._embedding
6956-
self._embedding = None
6966+
if has_attribute:
6967+
self._embedding = None
6968+
else:
6969+
del self._embedding
69576970
else:
69586971
raise ValueError("no embedding is provided and the graph is not planar")
69596972

0 commit comments

Comments
 (0)