Skip to content

Commit 0a3cfe2

Browse files
soehmsvincentmacri
andauthored
40839: Apply suggestions from code review
Co-authored-by: Vincent Macri <[email protected]>
1 parent db7f73f commit 0a3cfe2

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

.github/sync_labels.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -409,10 +409,10 @@ def get_commits(self):
409409

410410
self._commits = self.view('commits')
411411

412-
# ignore merge commits with the develop branch for _commit_date except positive review is set
412+
# ignore merge commits with the develop branch for _commit_date unless positive review is set
413413
date_commits = list(self._commits)
414414
if Status.positive_review.value not in self.get_labels():
415-
for com in date_commits:
415+
for com in self._commits:
416416
message = com['messageHeadline']
417417
if message.startswith('Merge') and 'develop' in message:
418418
debug('Ignore merge commit %s for commit_date' % com['oid'])

0 commit comments

Comments
 (0)