less enthusiasm in error messages

Author: fchapoton

src/sage/categories/crystals.py

@@ -1582,12 +1582,12 @@ def to_highest_weight(self, index_set = None):
                 sage: t.to_highest_weight()
                 Traceback (most recent call last):
                 ...
-                ValueError: This is not a highest weight crystals!
+                ValueError: this is not a highest weight crystal
             """
             from sage.categories.highest_weight_crystals import HighestWeightCrystals
             if index_set is None:
                 if HighestWeightCrystals() not in self.parent().categories():
-                    raise ValueError("This is not a highest weight crystals!")
+                    raise ValueError("this is not a highest weight crystal")
                 index_set = self.index_set()
             for i in index_set:
                 next = self.e(i)
@@ -1623,12 +1623,12 @@ def to_lowest_weight(self, index_set = None):
                 sage: t.to_lowest_weight()
                 Traceback (most recent call last):
                 ...
-                ValueError: This is not a highest weight crystals!
+                ValueError: this is not a highest weight crystal
             """
             from sage.categories.highest_weight_crystals import HighestWeightCrystals
             if index_set is None:
                 if HighestWeightCrystals() not in self.parent().categories():
-                    raise ValueError("This is not a highest weight crystals!")
+                    raise ValueError("this is not a highest weight crystal")
                 index_set = self.index_set()
             for i in index_set:
                 next = self.f(i)

src/sage/categories/finite_coxeter_groups.py

@@ -827,11 +827,11 @@ def coxeter_knuth_neighbor(self, w):
                 sage: w.coxeter_knuth_neighbor(word)
                 Traceback (most recent call last):
                 ...
-                NotImplementedError: This has only been implemented in finite type A so far!
+                NotImplementedError: this has only been implemented in finite type A so far
             """
             C = self.parent().cartan_type()
             if not C[0] == 'A':
-                raise NotImplementedError("This has only been implemented in finite type A so far!")
+                raise NotImplementedError("this has only been implemented in finite type A so far")
             d = []
             for i in range(2,len(w)):
                 v = [j for j in w]

src/sage/categories/finite_groups.py

@@ -134,7 +134,7 @@ def cayley_graph_disabled(self, connecting_set=None):
             else:
                 for g in connecting_set:
                     if g not in self:
-                        raise RuntimeError("Each element of the connecting set must be in the group!")
+                        raise RuntimeError("each element of the connecting set must be in the group")
                 connecting_set = [self(g) for g in connecting_set]
             from sage.graphs.digraph import DiGraph
             arrows = {}

src/sage/coding/binary_code.pyx

@@ -777,7 +777,8 @@ cdef class BinaryCode:
             self.nwords = 2 * other_nwords
             nrows = self.nrows
             nwords = self.nwords
-        else: raise NotImplementedError("!")
+        else:
+            raise NotImplementedError
 
         if self.nrows >= self.radix or self.ncols > self.radix:
             raise NotImplementedError("Columns and rows are stored as ints. This code is too big.")

src/sage/combinat/designs/incidence_structures.py

@@ -1383,7 +1383,7 @@ def relabel(self, perm=None, inplace=True):
             raise ValueError("perm argument must be None, a list or a dictionary")
 
         if len(set(perm.values())) != len(perm):
-            raise ValueError("Two points are getting relabelled with the same name !")
+            raise ValueError("two points are getting relabelled with the same name")
 
         self._points = [perm[x] for x in self._points]
         if self._points == list(range(self.num_points())):

src/sage/combinat/designs/steiner_quadruple_systems.py

@@ -741,10 +741,10 @@ def steiner_quadruple_system(n, check = False):
         nn = (n+10) // 12
         sqs = twelve_n_minus_ten(steiner_quadruple_system(nn, check = False))
     else:
-        raise ValueError("This shouldn't happen !")
+        raise ValueError("this should never happen")
 
     if check and not sqs.is_t_design(3,n,4,1):
-        raise RuntimeError("Something is very very wrong.")
+        raise RuntimeError("something is very very wrong")
 
     return sqs
 

src/sage/databases/sql_db.py

@@ -1254,8 +1254,7 @@ def get_skeleton(self, check=False):
             d = construct_skeleton(self)
             if d == self.__skeleton__:
                 return d
-            else:
-                raise RuntimeError("Skeleton structure is out of whack!")
+            raise RuntimeError("skeleton structure is out of whack")
         return self.__skeleton__
 
     def query(self, *args, **kwds):

src/sage/groups/cubic_braid.py

@@ -1901,7 +1901,7 @@ def classical_invariant_form(self):
             self._create_classical_realization()
 
         if self._classical_invariant_form is None:
-            raise ValueError("no classical invariant form defined!")
+            raise ValueError("no classical invariant form defined")
 
         return self._classical_invariant_form
 

src/sage/groups/generic.py

@@ -1033,7 +1033,7 @@ def linear_relation(P, Q, operation='+', identity=None, inverse=None, op=None):
                     m1 * h)
         except ValueError:
             pass  # to next h
-    raise ValueError("No solution found in linear_relation!")
+    raise ValueError("no solution found in linear_relation")
 
 ################################################################
 #

src/sage/libs/glpk/error.pyx

@@ -29,10 +29,10 @@ class GLPKError(MIPSolverException):
     EXAMPLES::
 
         sage: from sage.libs.glpk.error import GLPKError
-        sage: raise GLPKError("trouble!")
+        sage: raise GLPKError("trouble")
         Traceback (most recent call last):
         ...
-        GLPKError: trouble!
+        GLPKError: trouble
     """
     pass