You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
gh-35887: gap: switch to libgap API for GAP function calls
### 📚 Description
Switch to the official libgap API for making function calls. <s>This
also simplifies the code quite a bit.</s> And it makes it possible to
call non-standard GAP functions (i.e. functions which are not
`T_FUNCTION` but just an arbitrary objects for which a function call
method has been installed).
<s>As a caveat, I could *not* try this at all, as I currently cannot
compile SageMath (it runs into weird errors, and I don't have time to
debug this, sorry). In particular I just looked at the Cython
documentation to find out how to get a raw pointer to the content of an
array; but I am not even sure that I got the syntax right, let alone the
semantics. But I figured it's worth a shot.</s>
UPDATE: I decided to not try to use `GAP_CallFuncArray` anymore; it just
is impossible for me to figure out the right way to call it from Cython
when I can only test my changes by pushing them here. Instead a more
modest but hopefully less problematic approach is now used.
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. It should be `[x]` not `[x
]`. -->
- [ ] The title is concise, informative, and self-explanatory.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on
- #12345: short description why this is a dependency
- #34567: ...
-->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
URL: #35887
Reported by: Max Horn
Reviewer(s): Frédéric Chapoton
0 commit comments