Skip to content

Commit 0f17e65

Browse files
Corrected the error in functions
1 parent 14c225e commit 0f17e65

File tree

2 files changed

+40
-5
lines changed

2 files changed

+40
-5
lines changed

src/sage/groups/libgap_wrapper.pyx

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -347,7 +347,7 @@ class ParentLibGAP(SageObject):
347347

348348
def minimal_normal_subgroups(self):
349349
"""
350-
Return a list containing those nontrivial normal subgroups of the group that are minimal among the nontrivial normal subgroups.
350+
Return the nontrivial minimal normal subgroups ``self``.
351351
352352
EXAMPLES::
353353
@@ -357,12 +357,15 @@ class ParentLibGAP(SageObject):
357357
[0 6]
358358
) of Special Linear Group of degree 2 over Finite Field in z2 of size 7^2]
359359
"""
360-
return [self._subgroup_constructor(gap_subgroup) for gap_subgroup in self.gap().MinimalNormalSubgroups()]
360+
return [self._subgroup_constructor(gap_subgroup)
361+
for gap_subgroup in self._libgap.MinimalNormalSubgroups()]
361362

362363
def maximal_normal_subgroups(self):
363364
"""
364-
Return a list containing those proper normal subgroups of the group G that are maximal among the proper normal subgroups.
365-
Gives error if G/G' is infinite, yielding infinitely many maximal normal subgroups.
365+
Return the maximal proper normal subgroups of ``self``.
366+
367+
This raises an error if `G/[G, G]` is infinite, yielding infinitely
368+
many maximal normal subgroups.
366369
367370
EXAMPLES::
368371
@@ -372,7 +375,8 @@ class ParentLibGAP(SageObject):
372375
[0 6]
373376
) of Special Linear Group of degree 2 over Finite Field in z2 of size 7^2]
374377
"""
375-
return [self._subgroup_constructor(gap_subgroup) for gap_subgroup in self.gap().MaximalNormalSubgroups()]
378+
return [self._subgroup_constructor(gap_subgroup)
379+
for gap_subgroup in self._libgap.MaximalNormalSubgroups()]
376380

377381
@cached_method
378382
def gens(self):

src/sage/groups/perm_gps/permgroup.py

Lines changed: 31 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4106,6 +4106,37 @@ def isomorphism_type_info_simple_group(self):
41064106
else:
41074107
raise TypeError("group must be simple")
41084108

4109+
def minimal_normal_subgroups(self):
4110+
"""
4111+
Return the nontrivial minimal normal subgroups ``self``.
4112+
4113+
EXAMPLES::
4114+
4115+
sage: G = PermutationGroup([(1,2,3),(4,5)])
4116+
sage: G.minimal_normal_subgroups()
4117+
[Subgroup generated by [(4,5)] of (Permutation Group with generators [(4,5), (1,2,3)]),
4118+
Subgroup generated by [(1,2,3)] of (Permutation Group with generators [(4,5), (1,2,3)])]
4119+
"""
4120+
return [self.subgroup(gap_group=gap_subgroup)
4121+
for gap_subgroup in self._libgap_().MinimalNormalSubgroups()]
4122+
4123+
def maximal_normal_subgroups(self):
4124+
"""
4125+
Return the maximal proper normal subgroups of ``self``.
4126+
4127+
This raises an error if `G/[G, G]` is infinite, yielding infinitely
4128+
many maximal normal subgroups.
4129+
4130+
EXAMPLES::
4131+
4132+
sage: G = PermutationGroup([(1,2,3),(4,5)])
4133+
sage: G.maximal_normal_subgroups()
4134+
[Subgroup generated by [(1,2,3)] of (Permutation Group with generators [(4,5), (1,2,3)]),
4135+
Subgroup generated by [(4,5)] of (Permutation Group with generators [(4,5), (1,2,3)])]
4136+
"""
4137+
return [self.subgroup(gap_group=gap_subgroup)
4138+
for gap_subgroup in self._libgap_().MaximalNormalSubgroups()]
4139+
41094140
###################### Boolean tests #####################
41104141

41114142
def is_abelian(self):

0 commit comments

Comments
 (0)