suggested details

Author: fchapoton

src/sage/modular/abvar/homspace.py

@@ -482,13 +482,11 @@ def free_module(self):
 
     def gen(self, i=0):
         """
-        Return i-th generator of self.
+        Return i-th generator of ``self``.
 
         INPUT:
 
-
-        -  ``i`` - an integer
-
+        -  ``i`` -- an integer
 
         OUTPUT: a morphism
 
@@ -508,7 +506,7 @@ def gen(self, i=0):
 
     def ngens(self):
         """
-        Return number of generators of self.
+        Return number of generators of ``self``.
 
         OUTPUT: integer
 
@@ -661,10 +659,12 @@ def _calculate_product_gens(self):
 
     def _calculate_simple_gens(self):
         """
-        Calculate generators for self, where both the domain and codomain
-        for self are assumed to be simple abelian varieties. The saturation
-        of the span of these generators in self will be the full space of
-        homomorphisms from the domain of self to its codomain.
+        Calculate generators for ``self``, where both the domain and codomain
+        for ``self`` are assumed to be simple abelian varieties.
+
+        The saturation of the span of these generators in ``self``
+        will be the full space of homomorphisms from the domain of
+        ``self`` to its codomain.
 
         EXAMPLES::
 
@@ -759,13 +759,11 @@ def __init__(self, A, gens=None, category=None):
 
         INPUT:
 
+        -  ``A`` -- an abelian variety
 
-        -  ``A`` - an abelian variety
-
-        -  ``gens`` - (default: None); optional; if given
+        -  ``gens`` -- (default: ``None``); optional; if given
            should be a tuple of the generators as matrices
 
-
         EXAMPLES::
 
             sage: J0(23).endomorphism_ring()
@@ -808,12 +806,11 @@ def __init__(self, A, gens=None, category=None):
         self._A = A
 
         # Initialise self with the correct category.
-        # We need to initialise it as a ring first
         if category is None:
             homset_cat = A.category()
         else:
             homset_cat = category
-        # Remark: Ring.__init__ will automatically form the join
+        # Remark: Parent.__init__ will automatically form the join
         # of the category of rings and of homset_cat
         Parent.__init__(self, A.base_ring(), category=homset_cat.Endsets())
         Homspace.__init__(self, A, A, cat=homset_cat)
@@ -825,7 +822,7 @@ def __init__(self, A, gens=None, category=None):
 
     def _repr_(self):
         """
-        Return the string representation of self.
+        Return the string representation of ``self``.
 
         EXAMPLES::
 
@@ -853,18 +850,16 @@ def abelian_variety(self):
 
     def index_in(self, other, check=True):
         """
-        Return the index of self in other.
+        Return the index of ``self`` in ``other``.
 
         INPUT:
 
-
-        -  ``other`` - another endomorphism subring of the
+        -  ``other`` -- another endomorphism subring of the
            same abelian variety
 
-        -  ``check`` - bool (default: True); whether to do some
+        -  ``check`` -- bool (default: ``True``); whether to do some
            type and other consistency checks
 
-
         EXAMPLES::
 
             sage: R = J0(33).endomorphism_ring()

src/sage/modular/modsym/ambient.py

@@ -169,7 +169,7 @@ def __init__(self, group, weight, sign, base_ring,
 
         sign = int(sign)
         if base_ring not in Fields():
-            raise TypeError("base_ring must be a commutative ring")
+            raise TypeError("base_ring must be a field")
 
         if character is None and arithgroup.is_Gamma0(group):
             character = TrivialCharacter(group.level(), base_ring)
@@ -2983,7 +2983,7 @@ def _compute_hecke_matrix_prime(self, p, rows=None):
             self._hecke_matrices = {}
         except KeyError:
             pass
-        tm = verbose("Computing Hecke operator T_%s" % p)
+        tm = verbose(f"Computing Hecke operator T_{p}")
 
         H = heilbronn.HeilbronnCremona(p)
         # H = heilbronn.HeilbronnMerel(p)