avoid Algebra in polynomials and move is_commutative

Author: fchapoton

src/sage/categories/commutative_rings.py

@@ -47,6 +47,24 @@ class CommutativeRings(CategoryWithAxiom):
 
     """
     class ParentMethods:
+        def is_commutative(self) -> bool:
+            """
+            Return whether the ring is commutative.
+
+            The answer is ``True`` only if the category is a sub-category of
+            ``CommutativeRings``.
+
+            It is recommended to use instead ``R in Rings().Commutative()``.
+
+            EXAMPLES::
+
+                sage: QQ.is_commutative()
+                True
+                sage: QQ['x,y,z'].is_commutative()
+                True
+            """
+            return True
+
         def _test_divides(self, **options):
             r"""
             Run generic tests on the method :meth:`divides`.

src/sage/categories/rings.py

@@ -322,6 +322,23 @@ def is_ring(self) -> bool:
             """
             return True
 
+        def is_commutative(self) -> bool:
+            """
+            Return whether the ring is commutative.
+
+            The answer is ``True`` only if the category is a sub-category of
+            ``CommutativeRings``.
+
+            It is recommended to use instead ``R in Rings().Commutative()``.
+
+            EXAMPLES::
+
+                sage: Q.<i,j,k> = QuaternionAlgebra(QQ, -1, -1)                             # needs sage.combinat sage.modules
+                sage: Q.is_commutative()                                                    # needs sage.combinat sage.modules
+                False
+            """
+            return False
+
         def is_zero(self) -> bool:
             """
             Return ``True`` if this is the zero ring.

src/sage/rings/polynomial/polynomial_ring.py

@@ -130,15 +130,15 @@
 
 """
 
-#*****************************************************************************
+# ****************************************************************************
 #       Copyright (C) 2006 William Stein <[email protected]>
 #
 # This program is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by
 # the Free Software Foundation, either version 2 of the License, or
 # (at your option) any later version.
-#                  http://www.gnu.org/licenses/
-#*****************************************************************************
+#                  https://www.gnu.org/licenses/
+# ****************************************************************************
 
 
 import sys
@@ -148,7 +148,7 @@
 import sage.categories as categories
 from sage.categories.morphism import IdentityMorphism
 
-from sage.rings.ring import (Algebra, CommutativeAlgebra, IntegralDomain,
+from sage.rings.ring import (Ring, IntegralDomain,
                              PrincipalIdealDomain, is_Ring)
 from sage.structure.element import is_RingElement
 import sage.rings.rational_field as rational_field
@@ -226,7 +226,7 @@ def is_PolynomialRing(x):
 
 #########################################################################################
 
-class PolynomialRing_general(Algebra):
+class PolynomialRing_general(Ring):
     """
     Univariate polynomial ring over a ring.
     """
@@ -303,7 +303,7 @@ def __init__(self, base_ring, name=None, sparse=False, implementation=None,
         self.Element = self._polynomial_class
         self.__cyclopoly_cache = {}
         self._has_singular = False
-        Algebra.__init__(self, base_ring, names=name, normalize=True, category=category)
+        Ring.__init__(self, base_ring, names=name, normalize=True, category=category)
         self._populate_coercion_lists_(convert_method_name='_polynomial_')
 
     def __reduce__(self):
@@ -1709,7 +1709,7 @@ def monics( self, of_degree=None, max_degree=None ):
         raise ValueError("you should pass exactly one of of_degree and max_degree")
 
 
-class PolynomialRing_commutative(PolynomialRing_general, CommutativeAlgebra):
+class PolynomialRing_commutative(PolynomialRing_general):
     """
     Univariate polynomial ring over a commutative ring.
     """

src/sage/rings/ring.pyx

@@ -686,24 +686,6 @@ cdef class Ring(ParentWithGens):
             return x
         return self._one_element
 
-    def is_commutative(self):
-        """
-        Return ``True`` if this ring is commutative.
-
-        EXAMPLES::
-
-            sage: QQ.is_commutative()
-            True
-            sage: QQ['x,y,z'].is_commutative()
-            True
-            sage: Q.<i,j,k> = QuaternionAlgebra(QQ, -1, -1)                             # needs sage.combinat sage.modules
-            sage: Q.is_commutative()                                                    # needs sage.combinat sage.modules
-            False
-        """
-        if self.is_zero():
-            return True
-        raise NotImplementedError
-
     def is_field(self, proof = True):
         """
         Return ``True`` if this ring is a field.