Skip to content

Commit 1b95945

Browse files
author
Release Manager
committed
gh-39573: Doctest for defining multivariate polynomial ring over InfinityRing <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes #12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes #12345". --> Fixes #34675 Previously, defining a multivariate polynomial ring over InfinityRing would incorrectly result in an error. As mentioned in the comments under the linked issue, this behaviour was fixed in version 10.3 but a doctest was still needed. This pull request adds the required doctest, verifying that the statement `PolynomialRing(InfinityRing,2,'x')` correctly generates a ring instead of throwing an error. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [X] The title is concise and informative. - [X] The description explains in detail what this PR is about. - [X] I have linked a relevant issue or discussion. - [X] I have created tests covering the changes. - [X] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - #12345: short description why this is a dependency --> <!-- - #34567: ... --> URL: #39573 Reported by: Caleb Van't Land Reviewer(s):
2 parents 1bc98df + 2732887 commit 1b95945

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

src/sage/rings/polynomial/polynomial_ring_constructor.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -621,6 +621,12 @@ def PolynomialRing(base_ring, *args, **kwds):
621621
....: '_test_distributivity', '_test_prod'])
622622
sage: R.<x,y> = PolynomialRing(RIF,2)
623623
sage: TestSuite(R).run(skip=['_test_elements', '_test_elements_eq_transitive'])
624+
625+
We verify that multivariate polynomial rings over ``InfinityRing`` from
626+
:issue:`34675` are fixed::
627+
628+
sage: PolynomialRing(InfinityRing, 2, 'x')
629+
Multivariate Polynomial Ring in x0, x1 over The Infinity Ring
624630
"""
625631
from sage.rings.semirings.tropical_semiring import TropicalSemiring
626632
if base_ring not in Rings() and not isinstance(base_ring, TropicalSemiring):

0 commit comments

Comments
 (0)