Skip to content

Commit 1fc0dde

Browse files
author
Release Manager
committed
gh-38215: Fix typo "sage.ring" in docstrings The correct module path is "sage.rings" instead of "sage.ring". In sage/modular/pollack_stevens/padic_lseries.py and in sage/structure/factory.pyx the typo prevents doctests from being run because the "needs" requirement canot be fulfilled. In sage/rings/polynomial/padics/polynomial_padic.py the typo is merely cosmetic. See brief [discussion in Sage Support Group](https://groups.google.com/g/sage-support/c/Msx0QJF7rpA) ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> / - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - #12345: short description why this is a dependency --> <!-- - #34567: ... --> URL: #38215 Reported by: Jens-Erik Riedel Reviewer(s): David Coudert, Julian Rüth
2 parents 11bf188 + d08315f commit 1fc0dde

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

src/sage/modular/pollack_stevens/padic_lseries.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# sage.doctest: needs sage.ring.padics
1+
# sage.doctest: needs sage.rings.padics
22
r"""
33
`p`-adic `L`-series attached to overconvergent eigensymbols
44
@@ -174,7 +174,7 @@ def __eq__(self, other):
174174
175175
sage: E = EllipticCurve('11a')
176176
sage: L = E.padic_lseries(11,implementation="pollackstevens",precision=6) # long time
177-
sage: L == loads(dumps(L)) # indirect doctest long time
177+
sage: L == loads(dumps(L)) # indirect doctest, long time
178178
True
179179
"""
180180
if not isinstance(other, pAdicLseries):

src/sage/rings/polynomial/padics/polynomial_padic.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -274,7 +274,7 @@ def root_field(self, names, check_irreducible=True, **kwds):
274274
275275
* ``check_irreducible`` -- check whether the polynomial is irreducible
276276
277-
* ``kwds`` -- see :meth:`sage.ring.padics.padic_generic.pAdicGeneric.extension`
277+
* ``kwds`` -- see :meth:`sage.rings.padics.padic_generic.pAdicGeneric.extension`
278278
279279
EXAMPLES::
280280

src/sage/structure/factory.pyx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -520,7 +520,7 @@ cdef class UniqueFactory(SageObject):
520520
The ``GF`` factory used to have a custom :meth:`other_keys`
521521
method, but this was removed in :issue:`16934`::
522522
523-
sage: # needs sage.libs.linbox sage.ring.finite_rings
523+
sage: # needs sage.libs.linbox sage.rings.finite_rings
524524
sage: key, _ = GF.create_key_and_extra_args(27, 'k'); key
525525
(27, ('k',), x^3 + 2*x + 1, 'givaro', 3, 3, True, None, 'poly', True, True, True)
526526
sage: K = GF.create_object(0, key); K

0 commit comments

Comments
 (0)