sage.combinat.root_system: Fixups for modularization changes

Author: Matthias Koeppe

src/sage/combinat/root_system/ambient_space.py

@@ -119,11 +119,11 @@ def _test_norm_of_simple_roots(self, **options):
         T = self.cartan_type()
         try:
             D = T.symmetrizer()
-            alpha = self.simple_roots(sort=False)
+            alpha = self.simple_roots()
             DD = T.dynkin_diagram()
         except ImportError:  # Dynkin diagrams need sage.graphs
             return
-        for C in DD.connected_components():
+        for C in DD.connected_components(sort=False):
             tester.assertEqual(len( set( alpha[i].scalar(alpha[i]) / D[i] for i in C ) ), 1)
 
     # FIXME: attribute or method?

src/sage/combinat/root_system/non_symmetric_macdonald_polynomials.py

@@ -652,11 +652,11 @@ class NonSymmetricMacdonaldPolynomials(CherednikOperatorsEigenvectors):
         sage: La = R.weight_space().basis()
         sage: LS = crystals.ProjectedLevelZeroLSPaths(2*La[1])
         sage: (E[-2*omega[1]].map_coefficients(lambda x: x.subs(t=0))   # long time (15s)
-        ....:   == LS.one_dimensional_configuration_sum(q)
+        ....:   == LS.one_dimensional_configuration_sum(q))
         True
         sage: LS = crystals.ProjectedLevelZeroLSPaths(La[1] + La[2])
-        sage: (E[-omega[1]-omega[2]].map_coefficients(lambda x: x.subs(t=0))    # long time (45s)
-        ....:   == LS.one_dimensional_configuration_sum(q)
+        sage: (E[-omega[1] - omega[2]].map_coefficients(lambda x: x.subs(t=0))  # long time (45s)
+        ....:   == LS.one_dimensional_configuration_sum(q))
         True
 
     ::

src/sage/combinat/root_system/root_lattice_realization_algebras.py

@@ -52,7 +52,7 @@ def some_elements(self):
 
                 sage: A = RootSystem(["A",2,1]).ambient_space().algebra(QQ)
                 sage: A.some_elements()
-                [B[2*e[0] + 2*e[1] + 3*e[2]]]
+                [B[2*e[0] + 2*e[1] + 3*e[2]]...]
                 sage: A.some_elements()                                                 # needs sage.graphs
                 [B[2*e[0] + 2*e[1] + 3*e[2]],
                  B[-e[0] + e[2] + e['delta']],
@@ -64,7 +64,13 @@ def some_elements(self):
 
                 sage: A = RootSystem(["B",2]).weight_space().algebra(QQ)
                 sage: A.some_elements()
-                [B[2*Lambda[1] + 2*Lambda[2]], B[Lambda[1]], B[Lambda[2]]]
+                [B[2*Lambda[1] + 2*Lambda[2]], ... B[Lambda[1]], B[Lambda[2]]]
+                sage: A.some_elements()                                                 # needs sage.graphs
+                [B[2*Lambda[1] + 2*Lambda[2]],
+                 B[2*Lambda[1] - 2*Lambda[2]],
+                 B[-Lambda[1] + 2*Lambda[2]],
+                 B[Lambda[1]],
+                 B[Lambda[2]]]
             """
             return [self.monomial(weight) for weight in self.basis().keys().some_elements()]
 

src/sage/combinat/root_system/weight_space.py

@@ -133,7 +133,7 @@ class WeightSpace(CombinatorialFreeModule):
     TESTS::
 
         sage: for ct in (CartanType.samples(crystallographic=True)                      # needs sage.graphs
-        ....:             + [CartanType(["A",2], ["C",5,1])]:
+        ....:             + [CartanType(["A",2], ["C",5,1])]):
         ....:     TestSuite(ct.root_system().weight_lattice()).run()
         ....:     TestSuite(ct.root_system().weight_space()).run()
         sage: for ct in CartanType.samples(affine=True):                                # needs sage.graphs