Skip to content

Commit 2868a93

Browse files
author
Release Manager
committed
gh-40390: remove some unused variables in libs/ found using cython-lint ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. URL: #40390 Reported by: Frédéric Chapoton Reviewer(s): Travis Scrimshaw
2 parents b4523ef + 6056073 commit 2868a93

File tree

13 files changed

+13
-26
lines changed

13 files changed

+13
-26
lines changed

src/sage/libs/flint/fmpz_poly_sage.pyx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,6 @@ cdef class Fmpz_poly(SageObject):
5151
3 3 5 7
5252
"""
5353
cdef Py_ssize_t i
54-
cdef long c
5554
cdef Integer w
5655
if isinstance(v, str):
5756
if not fmpz_poly_set_str(self.poly, str_to_bytes(v)):

src/sage/libs/gap/element.pyx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3020,8 +3020,6 @@ cdef class GapElement_Permutation(GapElement):
30203020
sage: type(_)
30213021
<class 'sage.groups.perm_gps.permgroup_element.PermutationGroupElement'>
30223022
"""
3023-
cdef PermutationGroupElement one_c
3024-
30253023
libgap = self.parent()
30263024
lst = libgap.ListPerm(self)
30273025

src/sage/libs/gap/util.pyx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,6 @@ cdef class ObjWrapper():
6969
sage: x == y
7070
True
7171
"""
72-
cdef result
7372
cdef Obj self_value = self.value
7473
cdef Obj other_value = other.value
7574
if op == Py_LT:
@@ -350,7 +349,7 @@ cdef Obj gap_eval(str gap_string) except? NULL:
350349
"""
351350
initialize()
352351
cdef Obj result
353-
cdef int i, j, nresults
352+
cdef int nresults
354353

355354
# Careful: We need to keep a reference to the bytes object here
356355
# so that Cython doesn't deallocate it before GAP is done with

src/sage/libs/lcalc/lcalc_Lfunction.pyx

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -311,18 +311,19 @@ cdef class Lfunction:
311311
[14.1347251417..., 21.0220396387..., 25.0108575801...]
312312
"""
313313
cdef doublevec result
314-
cdef double myresult
315314
cdef int i
316315
cdef RealNumber real_T1 = RRR(T1)
317316
cdef RealNumber real_T2 = RRR(T2)
318317
cdef RealNumber real_stepsize = RRR(stepsize)
319318
sig_on()
320-
self._find_zeros_v( mpfr_get_d(real_T1.value, MPFR_RNDN), mpfr_get_d(real_T2.value, MPFR_RNDN), mpfr_get_d(real_stepsize.value, MPFR_RNDN),&result)
319+
self._find_zeros_v(mpfr_get_d(real_T1.value, MPFR_RNDN),
320+
mpfr_get_d(real_T2.value, MPFR_RNDN),
321+
mpfr_get_d(real_stepsize.value, MPFR_RNDN), &result)
321322
sig_off()
322-
i=result.size()
323+
i = result.size()
323324
returnvalue = []
324325
for i in range(result.size()):
325-
returnvalue.append( RRR(result.ind(i)))
326+
returnvalue.append(RRR(result.ind(i)))
326327
result.clear()
327328
return returnvalue
328329

src/sage/libs/meataxe.pyx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,10 +51,9 @@ cdef Matrix_t *rawMatrix(int Field, list entries) except NULL:
5151
"""
5252
cdef Matrix_t *M = MatAlloc(Field, len(entries), len(entries[0]))
5353
cdef PTR x = M.Data
54-
cdef int idx, i, j
54+
cdef int i, j
5555
cdef list dt_i
5656
for i in range(M.Nor):
57-
idx = 0
5857
dt_i = entries[i]
5958
for j in range(M.Noc):
6059
FfInsert(x, j, FfFromInt(dt_i[j]))

src/sage/libs/mpmath/ext_impl.pyx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -267,7 +267,7 @@ cdef MPF_set_tuple(MPF *x, tuple value):
267267
"""
268268
#cdef int sign
269269
cdef Integer man
270-
sign, _man, exp, bc = value
270+
sign, _man, exp, _ = value
271271
if isinstance(_man, Integer):
272272
man = <Integer>_man
273273
else:

src/sage/libs/mpmath/utils.pyx

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -164,8 +164,7 @@ cdef mpfr_from_mpfval(mpfr_t res, tuple x):
164164
cdef int sign
165165
cdef Integer man
166166
cdef long exp
167-
cdef long bc
168-
sign, man, exp, bc = x
167+
sign, man, exp, _ = x
169168
if man:
170169
mpfr_set_z(res, man.value, MPFR_RNDZ)
171170
if sign:
@@ -320,7 +319,6 @@ def sage_to_mpmath(x, prec):
320319
sage: a.sage_to_mpmath({'n':0.5}, 53)
321320
{'n': mpf('0.5')}
322321
"""
323-
cdef RealNumber y
324322
if isinstance(x, Element):
325323
if isinstance(x, Integer):
326324
return int(<Integer>x)
@@ -340,7 +338,7 @@ def sage_to_mpmath(x, prec):
340338
if isinstance(x, (tuple, list)):
341339
return type(x)([sage_to_mpmath(v, prec) for v in x])
342340
if isinstance(x, dict):
343-
return dict([(k, sage_to_mpmath(v, prec)) for (k, v) in x.items()])
341+
return {k: sage_to_mpmath(v, prec) for k, v in x.items()}
344342
return x
345343

346344

src/sage/libs/ntl/ntl_ZZ_p.pyx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,6 @@ cdef class ntl_ZZ_p():
112112
# self.c._assert_is_current_modulus() # The context was restored in __new__
113113

114114
cdef ZZ_c temp, num, den
115-
cdef long failed
116115
if v is not None:
117116
if isinstance(v, ntl_ZZ_p):
118117
self.x = (<ntl_ZZ_p>v).x

src/sage/libs/ntl/ntl_mat_ZZ.pyx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -228,9 +228,8 @@ cdef class ntl_mat_ZZ():
228228
sage: M != 0
229229
True
230230
"""
231-
cdef ntl_mat_ZZ b
232231
try:
233-
b = <ntl_mat_ZZ?>other
232+
<ntl_mat_ZZ?>other
234233
except TypeError:
235234
return NotImplemented
236235
return PyObject_RichCompare(self.list(), other.list(), op)

src/sage/libs/pari/convert_sage.pyx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -274,7 +274,6 @@ cpdef gen_to_sage(Gen z, locals=None):
274274
cdef long t = typ(g)
275275
cdef long tx, ty
276276
cdef Gen real, imag, prec, xprec, yprec
277-
cdef Py_ssize_t i, j, nr, nc
278277

279278
if t == t_INT:
280279
return Integer(z)

0 commit comments

Comments
 (0)