Skip to content

Commit 2ef76f3

Browse files
author
Release Manager
committed
gh-36454: Remove `tomli` from some build dependencies <!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes #1234" use "Introduce new method to calculate 1+1" --> <!-- Describe your changes here in detail --> No longer needed because our current version of `flit_core` vendors it. Also eliminates one use of `--no-build-isolation`. <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes #12345". --> <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [x] The title is concise, informative, and self-explanatory. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - #12345: short description why this is a dependency - #34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: #36454 Reported by: Matthias Köppe Reviewer(s): Kwankyu Lee
2 parents 4faf2ae + c780523 commit 2ef76f3

File tree

4 files changed

+4
-9
lines changed

4 files changed

+4
-9
lines changed

build/pkgs/backcall/dependencies

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
| $(PYTHON_TOOLCHAIN) flit_core tomli $(PYTHON)
1+
| $(PYTHON_TOOLCHAIN) flit_core $(PYTHON)
22

33
----------
44
All lines of this file are ignored except the first.

build/pkgs/entrypoints/dependencies

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
| $(PYTHON_TOOLCHAIN) flit_core tomli $(PYTHON)
1+
| $(PYTHON_TOOLCHAIN) flit_core $(PYTHON)
22

33
----------
44
All lines of this file are ignored except the first.

build/pkgs/pyparsing/dependencies

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
| pip wheel flit_core tomli $(PYTHON)
1+
| pip wheel flit_core $(PYTHON)
22

33
----------
44
All lines of this file are ignored except the first.

build/pkgs/tomli/spkg-install.in

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,2 @@
11
cd src
2-
# tomli's build system, flit_core, has a runtime dependency on tomli.
3-
# Hence we make the uninstalled tomli sources available during the installation
4-
# and disable build isolation -- which would require a tomli wheel to
5-
# be available for setting up the build environment.
6-
export PYTHONPATH="$(pwd)"
7-
sdh_pip_install --no-build-isolation .
2+
sdh_pip_install .

0 commit comments

Comments
 (0)