Replace all uses of SAGE_SHARE in sagelib

Author: antonio-rojas

src/sage/combinat/cluster_algebra_quiver/mutation_type.py

@@ -1268,12 +1268,12 @@ def load_data(n: int, user=True) -> dict:
            ('BKO', (((1, 0), (3, -1)), ((2, 1), (1, -3)))),
            ('BP_', (((0, 1), (2, -2)), ((1, 2), (1, -3)), ((2, 0), (3, -1))))])]
     """
-    from sage.env import DOT_SAGE, SAGE_SHARE
+    from sage.env import DOT_SAGE, sage_data_paths
 
     # we check
     # - if the data is stored by the user, and if this is not the case
     # - if the data is stored by the optional package install
-    paths = [Path(SAGE_SHARE)]
+    paths = list(sage_data_paths())
     if user:
         paths.append(Path(DOT_SAGE))
     data = {}

src/sage/databases/cremona.py

@@ -20,8 +20,8 @@
 This causes the latest version of the database to be downloaded from
 the internet.
 
-Both the mini and full versions of John Cremona's tables are stored in
-SAGE_SHARE/cremona as SQLite databases. The mini version has the layout::
+Both the mini and full versions of John Cremona's tables are stored
+as SQLite databases. The mini version has the layout::
 
     CREATE TABLE t_class(conductor INTEGER, class TEXT PRIMARY KEY, rank INTEGER);
     CREATE TABLE t_curve(class TEXT, curve TEXT PRIMARY KEY, eqn TEXT UNIQUE, tors INTEGER);
@@ -115,8 +115,8 @@ def build(name, data_tgz, largest_conductor=0, mini=False, decompress=True):
 
         sage: d = sage.databases.cremona.build('cremona','ecdata.tgz')   # not tested
     """
-    from sage.env import SAGE_SHARE
-    db_path = os.path.join(SAGE_SHARE,'cremona',name.replace(' ','_')+'.db')
+    from sage.env import DOT_SAGE
+    db_path = os.path.join(DOT_SAGE, 'db', 'cremona', name.replace(' ','_')+'.db')
     if os.path.exists(db_path):
         raise RuntimeError('Please (re)move %s before building ' % db_path
                 + 'database')

src/sage/databases/cunningham_tables.py

@@ -19,7 +19,7 @@
 from sage.misc.cachefunc import cached_function
 from sage.rings.integer import Integer
 from sage.misc.persist import load
-from sage.env import SAGE_SHARE
+from sage.env import sage_data_paths
 
 
 @cached_function
@@ -43,11 +43,11 @@ def cunningham_prime_factors():
          17,
          ...
     """
-    file = os.path.join(SAGE_SHARE,'cunningham_tables','cunningham_prime_factors.sobj')
-    if os.path.exists(file):
-        return [Integer(_) for _ in load(file)]
-    else:
-        from warnings import warn
-        warn("You might consider installing the optional package for factoring Cunningham numbers"
-             " with the following command: ``sage -i cunningham_tables``")
-        return []
+    for path in sage_data_paths('cunningham_tables'):
+        file = os.path.join(path, 'cunningham_prime_factors.sobj')
+        if os.path.exists(file):
+            return [Integer(_) for _ in load(file)]
+
+    from warnings import warn
+    warn("The optional cunningham_tables package for factoring Cunningham numbers is not installed")
+    return []

src/sage/databases/db_modular_polynomials.py

@@ -52,14 +52,14 @@ def _dbz_to_string(name) -> str:
         sage: _dbz_to_string('PolHeeg/Cls/0000001-0005000/pol.0000003.dbz')
         '0\n1\n'
     """
-    from sage.env import SAGE_SHARE
-    filename = Path(SAGE_SHARE) / 'kohel' / name
-    try:
-        with open(filename, 'rb') as f:
-            data = bz2.decompress(f.read())
-    except OSError:
-        raise FileNotFoundError('file not found in the Kohel database')
-    return data.decode()
+    from sage.env import sage_data_paths
+    for path in sage_data_paths('kohel'):
+        filename = Path(path) / name
+        if os.path.exists(filename):
+            with open(filename, 'rb') as f:
+                data = bz2.decompress(f.read())
+            return data.decode()
+    raise FileNotFoundError('file not found in the Kohel database')
 
 
 def _dbz_to_integer_list(name) -> list[list]:

src/sage/databases/jones.py

@@ -73,7 +73,6 @@
 from sage.rings.rational_field import RationalField
 from sage.rings.polynomial.polynomial_ring_constructor import PolynomialRing
 from sage.combinat.subset import powerset
-from sage.env import SAGE_SHARE
 
 from sage.misc.persist import load, save
 

src/sage/databases/odlyzko.py

@@ -29,7 +29,7 @@
 import os
 
 from sage.misc.persist import load
-from sage.env import SAGE_SHARE
+from sage.env import sage_data_paths
 
 
 def zeta_zeros():
@@ -54,6 +54,9 @@ def zeta_zeros():
         2001052
     """
     from sage.misc.verbose import verbose
-    sobj = os.path.join(SAGE_SHARE, 'odlyzko', 'zeros.sobj')
-    verbose("Loading Odlyzko database from " + sobj)
-    return load(sobj)
+    for path in sage_data_paths('odlyzko'):
+        sobj = os.path.join(path, 'zeros.sobj')
+        if os.path.exists(sobj):
+            verbose("Loading Odlyzko database from " + sobj)
+            return load(sobj)
+    raise FileNotFoundError('Could not find the odlyzko database')

src/sage/databases/sloane.py

@@ -87,7 +87,7 @@
 import ssl
 
 from sage.misc.verbose import verbose
-from sage.env import SAGE_SHARE
+from sage.env import DOT_SAGE, sage_data_paths
 from sage.rings.integer_ring import ZZ
 
 
@@ -101,7 +101,12 @@ def __init__(self):
         """
         Initialize the database but do not load any of the data.
         """
-        self.__path__ = os.path.join(SAGE_SHARE, 'sloane')
+        self.__path__ = os.path.join(DOT_SAGE, 'db', 'sloane')
+        for path in sage_data_paths('sloane'):
+            file_oeis = os.path.join(path, 'sloane-oeis.bz2')
+            file_names = os.path.join(path, 'sloane-names.bz2')
+            if os.path.exists(file_oeis) and os.path.exists(file_names):
+                self.__path__ = path
         self.__file__ = os.path.join(self.__path__, 'sloane-oeis.bz2')
         self.__file_names__ = os.path.join(self.__path__, 'sloane-names.bz2')
         self.__loaded__ = False

src/sage/databases/stein_watkins.py

@@ -137,7 +137,7 @@
 import bz2
 import os
 
-from sage.env import SAGE_SHARE
+from sage.env import sage_data_paths
 
 
 class SteinWatkinsIsogenyClass:
@@ -183,7 +183,13 @@ def __init__(self, num):
             raise RuntimeError("num (=%s) must be a nonnegative integer" % num)
         name = str(num)
         name = '0' * (3 - len(name)) + name
-        self._file = os.path.join(SAGE_SHARE, 'stein_watkins', 'a.%s.bz2' % name)
+        self._file = None
+        for path in sage_data_paths('stein_watkins'):
+            file = os.path.join(path, 'a.%s.bz2' % name)
+            if os.path.exists(file):
+                self._file = file
+        if not self._file:
+            raise FileNotFoundError('Could not find the Stein-Watkins database')
         self._iter = iter(self)
 
     def __repr__(self):
@@ -317,7 +323,13 @@ def __init__(self, num):
             raise RuntimeError("num (=%s) must be a nonnegative integer" % num)
         name = str(num)
         name = '0' * (2 - len(name)) + name
-        self._file = os.path.join(SAGE_SHARE, 'stein_watkins', 'p.%s.bz2' % name)
+        self._file = None
+        for path in sage_data_paths('stein_watkins'):
+            file = os.path.join(path, 'p.%s.bz2' % name)
+            if os.path.exists(file):
+                self._file = file
+        if not self._file:
+            raise FileNotFoundError('Could not find the Stein-Watkins database')
         self._iter = iter(self)
 
     def __repr__(self):

src/sage/databases/symbolic_data.py

@@ -91,10 +91,16 @@ def __init__(self):
             sage: sd = SymbolicData(); sd # optional - database_symbolic_data
             SymbolicData with 372 ideals
         """
-        from sage.env import SAGE_SHARE
-        path = os.path.join(SAGE_SHARE, 'symbolic_data')
-        self.__intpath = path + "/Data/XMLResources/INTPS/"
-        self.__genpath = path + "/Data/XMLResources/GenPS/"
+        from sage.env import sage_data_paths
+        self.__intpath = self.__genpath = None
+        for path in sage_data_paths('symbolic_data'):
+            intpath = path + "/Data/XMLResources/INTPS/"
+            genpath = path + "/Data/XMLResources/GenPS/"
+            if os.path.exists(intpath) and os.path.exists(genpath):
+                self.__intpath = intpath
+                self.__genpath = genpath
+        if not self.__intpath or not self.__genpath:
+            raise FileNotFoundError('Could not find the SymbolicData database')
 
     def get_ideal(self, name, base_ring=QQ, term_order='degrevlex'):
         """
@@ -218,4 +224,4 @@ def __dir__(self):
             self.__ideals = [s.replace('.', '__') for s in __ideals]
             return self.__ideals
         except OSError:
-            raise AttributeError("Could not find symbolic data, you should perhaps install the optional package")
+            raise AttributeError("Could not find symbolic data")

src/sage/features/__init__.py

@@ -72,7 +72,7 @@
 from pathlib import Path
 from tempfile import NamedTemporaryFile
 
-from sage.env import SAGE_LOCAL, SAGE_SHARE, SAGE_VENV
+from sage.env import SAGE_LOCAL, SAGE_VENV, sage_data_paths
 
 
 class TrivialClasscallMetaClass(type):
@@ -798,7 +798,7 @@ def __init__(self, name, filename, *, search_path=None, type='optional', **kwds)
         Feature.__init__(self, name, type=type, **kwds)
         self.filename = filename
         if search_path is None:
-            self.search_path = [SAGE_SHARE]
+            self.search_path = list(sage_data_paths())
         elif isinstance(search_path, str):
             self.search_path = [search_path]
         else: