suggested details

Author: fchapoton

src/sage/combinat/designs/orthogonal_arrays_find_recursive.pyx

@@ -732,67 +732,67 @@ cpdef find_brouwer_separable_design(int k,int n) noexcept:
         False
     """
     from sage.combinat.designs.orthogonal_arrays_build_recursive import brouwer_separable_design
-    cdef int q,x,baer_subplane_size, max_t, min_t, t,e1,e2,e3,e4
+    cdef int q, x, baer_subplane_size, max_t, min_t, t, e1, e2, e3, e4
 
-    for q in prime_powers(2,n):
-        baer_subplane_size = q**2+q+1
+    for q in prime_powers(2, n):
+        baer_subplane_size = q**2 + q + 1
         if baer_subplane_size > n:
             break
         #                       x <= q^2+1
         # <=>        n-t(q^2+q+1) <= q^2+1
         # <=>             n-q^2-1 <= t(q^2+q+1)
         # <=> (n-q^2-1)/(q^2+q+1) <= t
 
-        min_t = (n-q**2-1)/baer_subplane_size
-        max_t = min(n/baer_subplane_size,q**2-q+1)
+        min_t = (n - q**2 - 1) / baer_subplane_size
+        max_t = min(n / baer_subplane_size, q**2 - q + 1)
 
-        for t in range(min_t,max_t+1):
-            x = n - t*baer_subplane_size
-            e1 = int(x != q**2-q-t)
+        for t in range(min_t, max_t + 1):
+            x = n - t * baer_subplane_size
+            e1 = int(x != q**2 - q - t)
             e2 = int(x != 1)
             e3 = int(x != q**2)
-            e4 = int(x != t+q+1)
+            e4 = int(x != t + q + 1)
 
             # i)
             if (x == 0 and
-                is_available(k, t) and is_available(k, t+q)):
+                is_available(k, t) and is_available(k, t + q)):
                 return brouwer_separable_design, (k, t, q, x)
 
             # ii)
-            elif (x == t+q and
-                  is_available(k+e3, t) and
-                  is_available(k, t+q) and
-                  is_available(k+1 ,t+q+1)):
+            elif (x == t + q and
+                  is_available(k + e3, t) and
+                  is_available(k, t + q) and
+                  is_available(k + 1, t + q + 1)):
                 return brouwer_separable_design, (k, t, q, x)
 
             # iii)
-            elif (x == q**2-q+1-t and
+            elif (x == q**2 - q + 1 - t and
                   is_available(k, x) and
-                  is_available(k+e2, t+1)
-                  and is_available(k+1, t+q)):
+                  is_available(k + e2, t + 1)
+                  and is_available(k + 1, t + q)):
                 return brouwer_separable_design, (k, t, q, x)
 
             # iv)
-            elif (x == q**2+1 and
+            elif (x == q**2 + 1 and
                   is_available(k, x) and
-                  is_available(k+e4, t+1) and
-                  is_available(k+1 ,t+q+1)):
+                  is_available(k + e4, t + 1) and
+                  is_available(k + 1, t + q + 1)):
                 return brouwer_separable_design, (k, t, q, x)
 
             # v)
-            elif (0<x and x<q**2-q+1-t and (e1 or e2) and
+            elif (0 < x < q**2 - q + 1 - t and (e1 or e2) and
                   is_available(k, x) and
-                  is_available(k+e1, t) and
-                  is_available(k+e2, t+1) and
-                  is_available(k+1, t+q)):
+                  is_available(k + e1, t) and
+                  is_available(k + e2, t + 1) and
+                  is_available(k + 1, t + q)):
                 return brouwer_separable_design, (k, t, q, x)
 
             # vi)
-            elif (t+q<x and x<q**2+1 and (e3 or e4) and
+            elif (t + q < x < q**2 + 1 and (e3 or e4) and
                   is_available(k, x) and
-                  is_available(k+e3, t) and
-                  is_available(k+e4, t+1) and
-                  is_available(k+1, t+q+1)):
+                  is_available(k + e3, t) and
+                  is_available(k + e4, t + 1) and
+                  is_available(k + 1, t + q + 1)):
                 return brouwer_separable_design, (k, t, q, x)
 
     return False

src/sage/matrix/matrix0.pyx

@@ -386,7 +386,7 @@ cdef class Matrix(sage.structure.element.Matrix):
         of this matrix. If i, j are out of range, an IndexError is
         raised.
         """
-        if i<0 or i >= self._nrows or j<0 or j >= self._ncols:
+        if i < 0 or i >= self._nrows or j<0 or j >= self._ncols:
             raise IndexError("matrix index out of range")
 
     cdef check_mutability(self) noexcept:
@@ -419,7 +419,7 @@ cdef class Matrix(sage.structure.element.Matrix):
         else:
             self._cache = None
 
-        if i<0 or i >= self._nrows or j<0 or j >= self._ncols:
+        if i < 0 or i >= self._nrows or j < 0 or j >= self._ncols:
             raise IndexError("matrix index out of range")
 
     def set_immutable(self):
@@ -3706,7 +3706,7 @@ cdef class Matrix(sage.structure.element.Matrix):
                     if positive and not d[i] > 0:
                         return False
                     for j in d:
-                        if d[i] * self.get_unsafe(i, j) != sign * d[j] * self.get_unsafe(j,i):
+                        if d[i] * self.get_unsafe(i, j) != sign * d[j] * self.get_unsafe(j, i):
                             return False
         return L
 
@@ -4297,7 +4297,7 @@ cdef class Matrix(sage.structure.element.Matrix):
 
         for i from 0 <= i < self._nrows:
             for j from 0 <= j <= i:
-                if self.get_unsafe(i, j) != -self.get_unsafe(j,i):
+                if self.get_unsafe(i, j) != -self.get_unsafe(j, i):
                     return False
         return True
 
@@ -4843,10 +4843,10 @@ cdef class Matrix(sage.structure.element.Matrix):
         cdef Py_ssize_t j
         tmp = []
 
-        if i<0 or i >= self._ncols:
+        if i < 0 or i >= self._ncols:
             raise IndexError("matrix column index out of range")
         for j from 0 <= j < self._nrows:
-            if not self.get_is_zero_unsafe(j,i):
+            if not self.get_is_zero_unsafe(j, i):
                 tmp.append(j)
         return tmp
 

src/sage/stats/hmm/distributions.pyx

@@ -182,7 +182,7 @@ cdef class GaussianMixtureDistribution(Distribution):
             sage: hmm.GaussianMixtureDistribution([(1,-1,0)], eps=1e-3)
             1.0*N(-1.0,0.001)
         """
-        B = [[c if c >= 0 else 0,  mu, std if std > 0 else eps]
+        B = [[(c if c >= 0 else 0), mu, (std if std > 0 else eps)]
              for c, mu, std in B]
         if not B:
             raise ValueError("must specify at least one component of the mixture model")
@@ -197,9 +197,9 @@ cdef class GaussianMixtureDistribution(Distribution):
                 else:
                     for a in B:
                         a[0] /= s
-        self.c0 = TimeSeries([c/(sqrt2pi*std) for c,_,std in B])
-        self.c1 = TimeSeries([-1.0/(2*std*std) for _,_,std in B])
-        self.param = TimeSeries(sum([list(x) for x in B],[]))
+        self.c0 = TimeSeries([c/(sqrt2pi*std) for c, _, std in B])
+        self.c1 = TimeSeries([-1.0/(2*std*std) for _, _, std in B])
+        self.param = TimeSeries(sum([list(x) for x in B], []))
         self.fixed = IntList(self.c0._length)
 
     def __getitem__(self, Py_ssize_t i):