Skip to content

Commit 34e96ca

Browse files
author
Release Manager
committed
gh-40354: correct syntax in maxima's spkg-configure.m4 remove `$` to print the version correctly, and remove unneeded `"..."` the extra `$` leads to the minimal version not being printed, and extra `"..."` around minimal version are confusing (and not needed) ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - #12345: short description why this is a dependency --> <!-- - #34567: ... --> URL: #40354 Reported by: Dima Pasechnik Reviewer(s): Tobias Diez
2 parents 7860478 + fe97836 commit 34e96ca

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

build/pkgs/maxima/spkg-configure.m4

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
SAGE_SPKG_CONFIGURE([maxima], [
2-
m4_pushdef([SAGE_MAXIMA_MINVER],["5.45.0"])dnl this version and higher allowed
2+
m4_pushdef([SAGE_MAXIMA_MINVER],[5.45.0])dnl this version and higher allowed
33
SAGE_SPKG_DEPCHECK([ecl], [
44
dnl First check for the "maxima" executable in the user's PATH, because
55
dnl we still use pexpect to communicate with it in a few places.
6-
AC_CACHE_CHECK([for Maxima >= $SAGE_MAXIMA_MINVER], [ac_cv_path_MAXIMA], [
6+
AC_CACHE_CHECK([for Maxima >= SAGE_MAXIMA_MINVER], [ac_cv_path_MAXIMA], [
77
AC_PATH_PROGS_FEATURE_CHECK([MAXIMA], [maxima], [
88
maxima_version=`$ac_path_MAXIMA --version 2>&1 | tail -n 1\
99
| $SED -n -e 's/Maxima *\([[0-9]]*\.[[0-9]]*\.[[0-9]]*\)/\1/p'`

0 commit comments

Comments
 (0)