Skip to content

Commit 3585296

Browse files
author
Release Manager
committed
gh-35024: fix usage of verbose with positional argument The second argument of verbose is a time, not the level, some calls were incorrectly using a positional argument in this case. <!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes #1234" use "Introduce new method to calculate 1+1" --> ### 📚 Description <!-- Describe your changes here in detail --> <!-- Why is this change required? What problem does it solve? --> <!-- If it resolves an open issue, please link to the issue here. For example "Closes #1337" --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [ ] I have made sure that the title is self-explanatory and the description concisely explains the PR. - [ ] I have linked an issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open pull requests that this PR logically depends on --> <!-- - #xyz: short description why this is a dependency - #abc: ... --> URL: #35024 Reported by: Alex J Best Reviewer(s): Frédéric Chapoton
2 parents 932112f + cabd272 commit 3585296

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

src/sage/schemes/elliptic_curves/gal_reps.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -916,28 +916,28 @@ def image_type(self, p):
916916
a_ell = self._E.ap(ell)
917917
u = k(a_ell)**2 * k(ell)**(-1)
918918
if u == 3:
919-
verbose("found an element of order 6",2)
919+
verbose("found an element of order 6", level=2)
920920
# found an element of order 6:
921921
self.__image_type[p] = non_split_str
922922
return self.__image_type[p]
923923

924924
if u == 2 and not has_an_el_order_4:
925925
# found an element of order 4
926-
verbose("found an element of order 4",2)
926+
verbose("found an element of order 4", level=2)
927927
has_an_el_order_4 = True
928928
if has_an_el_order_3:
929929
self.__image_type[p] = s4_str
930930
return self.__image_type[p]
931931

932932
if u == 1 and not has_an_el_order_3:
933933
# found an element of order 3
934-
verbose("found an element of order 3",2)
934+
verbose("found an element of order 3", level=2)
935935
has_an_el_order_3 = True
936936
if has_an_el_order_4:
937937
self.__image_type[p] = s4_str
938938
return self.__image_type[p]
939939

940-
verbose("p=5 and we could not determine the image, yet", 2)
940+
verbose("p=5 and we could not determine the image, yet", level=2)
941941
# we have not yet determined the image, there are only the following possible subgroups of PGL_2
942942
# (unless we were unlucky and none of the elements of order 6 showed up above, for instance)
943943
# A_4 of order 12 with elements of order 2 and 3
@@ -995,15 +995,15 @@ def image_type(self, p):
995995
u = k(a_ell)**2 * k(ell)**(-1)
996996
if (u not in ex_setp) and could_be_exc == 1:
997997
# it can not be in the exceptional
998-
verbose("the image cannot be exceptional, found u=%s"%u,2)
998+
verbose("the image cannot be exceptional, found u=%s"%u, level=2)
999999
could_be_exc = 0
10001000
if a_ell != 0 and arith.kronecker(a_ell**2 - 4*ell,p) == 1 and could_be_non_split == 1:
10011001
# it can not be in the normalizer of the non-split Cartan
1002-
verbose("the image cannot be non-split, found u=%s"%u,2)
1002+
verbose("the image cannot be non-split, found u=%s"%u, level=2)
10031003
could_be_non_split = 0
10041004
if a_ell != 0 and arith.kronecker(a_ell**2 - 4*ell,p) == -1 and could_be_split == 1:
10051005
# it can not be in the normalizer of the split Cartan
1006-
verbose("the image cannot be split, found u=%s"%u,2)
1006+
verbose("the image cannot be split, found u=%s"%u, level=2)
10071007
could_be_split = 0
10081008

10091009
assert could_be_exc + could_be_split + could_be_non_split > 0, "bug in image_type."
@@ -1064,7 +1064,7 @@ def image_type(self, p):
10641064
K = self._E.division_field(p, 'z')
10651065
d = K.absolute_degree()
10661066

1067-
verbose("field of degree %s. try to compute Galois group"%(d),2)
1067+
verbose("field of degree %s. try to compute Galois group"%(d), level=2)
10681068
# If the degree is too big, we have no chance at the Galois
10691069
# group. K.galois_group calls is_galois which used to rely on
10701070
# pari's Galois group computations, so degree < 12

0 commit comments

Comments
 (0)