referee's suggestions done

Author: fchapoton

src/sage/combinat/crystals/fast_crystals.py

@@ -220,9 +220,9 @@ def _type_bc_init(self, l1, l2):
             4
         """
         if self._cartan_type[0] == 'B':
-            m1, m2 = [l1+l2, l1-l2]
+            m1, m2 = l1 + l2, l1 - l2
         else:
-            m1, m2 = [l1, l2]
+            m1, m2 = l1, l2
         for b in range(m2,-1,-1):
             for a in range(m1,m2-1,-1):
                 for c in range(b,a+1):

src/sage/combinat/words/finite_word.py

@@ -1684,9 +1684,9 @@ def reduced_rauzy_graph(self, n):
             g.allow_loops(True)
             g.allow_multiple_edges(True)
             for v in l:
-                i, = g.neighbors_in(v)
-                o, = g.neighbors_out(v)
-                g.add_edge(i, o, g.edge_label(i, v)[0]*g.edge_label(v, o)[0])
+                i = next(g.neighbors_in_iterator(v))
+                o = next(g.neighbors_out_iterator(v))
+                g.add_edge(i, o, g.edge_label(i, v)[0] * g.edge_label(v, o)[0])
                 g.delete_vertex(v)
         return g
 

src/sage/geometry/hyperbolic_space/hyperbolic_geodesic.py

@@ -1215,8 +1215,8 @@ def ideal_endpoints(self):
         """
         start = self._start.coordinates()
         end = self._end.coordinates()
-        x1, x2 = [real(k) for k in [start, end]]
-        y1, y2 = [imag(k) for k in [start, end]]
+        x1, x2 = real(start), real(end)
+        y1, y2 = imag(start), imag(end)
         M = self._model
         # infinity is the first endpoint, so the other ideal endpoint
         # is just the real part of the second coordinate

src/sage/modules/free_quadratic_module_integer_symmetric.py

@@ -325,7 +325,7 @@ def IntegralLatticeDirectSum(Lattices, return_embeddings=False):
 
         sage: L1 = IntegralLattice(2 * matrix.identity(2), [[1/2, 1/2]])
         sage: L2 = IntegralLattice("A3", [[1, 1, 2]])                                   # needs sage.graphs
-        sage: L, phi = IntegralLatticeDirectSum([L1, L2], True)                       # needs sage.graphs
+        sage: L, phi = IntegralLatticeDirectSum([L1, L2], True)                         # needs sage.graphs
         sage: L                                                                         # needs sage.graphs
         Lattice of degree 5 and rank 2 over Integer Ring
         Basis matrix:
@@ -345,7 +345,7 @@ def IntegralLatticeDirectSum(Lattices, return_embeddings=False):
     dims = [L_i.dimension() for L_i in Lattices]
     degrees = [L_i.degree() for L_i in Lattices]
     degree_tot = sum(degrees)
-    sum_degree = [sum(degrees[:i]) for i in range(N+1)]
+    sum_degree = [sum(degrees[:i]) for i in range(N + 1)]
     inner_product_list = [copy(L_i.inner_product_matrix()) for L_i in Lattices]
     IM = matrix.block_diagonal(inner_product_list)
     ambient = FreeQuadraticModule(ZZ,

src/sage/rings/invariants/reconstruction.py

@@ -186,7 +186,7 @@ def binary_quintic_coefficients_from_invariants(invariants, K=None, invariant_ch
     If the invariant `M` vanishes, then the coefficients are computed in a
     different way::
 
-        sage: A, B, C = [3, 1, 2]
+        sage: A, B, C = 3, 1, 2
         sage: M = 2*A*B - 3*C
         sage: M
         0
@@ -265,7 +265,7 @@ def binary_quintic_coefficients_from_invariants(invariants, K=None, invariant_ch
     M = 2*A*B - 3*C
     N = K(2)**-1 * (A*C-B**2)
     R2 = -K(2)**-1 * (A*N**2-2*B*M*N+C*M**2)
-    scale = [1,1,1,1,1,1]
+    scale = [1, 1, 1, 1, 1, 1]
     from sage.arith.misc import binomial
     from sage.misc.functional import sqrt
     if len(invariants) == 3:
@@ -274,8 +274,8 @@ def binary_quintic_coefficients_from_invariants(invariants, K=None, invariant_ch
         else:
             # if R2 is not a square, we scale the invariants in a suitable way
             # so that the 'new' R2 is a square
-            A, B, C = [R2*A, R2**2*B, R2**3*C]
-            M, N = [R2**3*M, R2**4*N]
+            A, B, C = R2 * A, R2**2 * B, R2**3 * C
+            M, N = R2**3 * M, R2**4 * N
             R = R2**5
     elif len(invariants) == 4:
         if invariants[3]**2 != R2:

src/sage/schemes/curves/affine_curve.py

@@ -1592,7 +1592,7 @@ def extension(self):
         t = 0
         # loop through the patches and blow up each until no patch has singular points
         while not_resolved:
-            BC, t_maps, pi, pts = [res[t][0], res[t][1], res[t][2], res[t][3]]
+            BC, t_maps, pi, pts = res[t][0], res[t][1], res[t][2], res[t][3]
             # check if there are any singular points in this patch
             if not pts:
                 t += 1
@@ -1762,7 +1762,7 @@ class AffinePlaneCurve_field(AffinePlaneCurve, AffineCurve_field):
     """
     _point = AffinePlaneCurvePoint_field
 
-    def has_vertical_asymptote(self):
+    def has_vertical_asymptote(self) -> bool:
         """
         Check if the curve is not a line and has vertical asymptotes.
 
@@ -1782,7 +1782,7 @@ def has_vertical_asymptote(self):
         dxy = f.coefficient({y: dy}).degree()
         return dxy > 0 and f.degree() > 1
 
-    def is_vertical_line(self):
+    def is_vertical_line(self) -> bool:
         """
         Check if the curve is a vertical line.