Roll back the changes of element.pyx

Author: cxzhong

src/sage/libs/gap/element.pyx

@@ -984,7 +984,7 @@ cdef class GapElement(RingElement):
             GAPError: Error, no method found!
             Error, no 1st choice method found for `+' on 2 arguments
         """
-        cdef volatile Obj result
+        cdef Obj result
         try:
             sig_GAP_Enter()
             sig_on()
@@ -1012,7 +1012,7 @@ cdef class GapElement(RingElement):
             ...
             GAPError: Error, no method found! ...
         """
-        cdef volatile Obj result
+        cdef Obj result
         try:
             sig_GAP_Enter()
             sig_on()
@@ -1041,7 +1041,7 @@ cdef class GapElement(RingElement):
             GAPError: Error, no method found!
             Error, no 1st choice method found for `*' on 2 arguments
         """
-        cdef volatile Obj result
+        cdef Obj result
         try:
             sig_GAP_Enter()
             sig_on()
@@ -1075,7 +1075,7 @@ cdef class GapElement(RingElement):
             ...
             GAPError: Error, Rational operations: <divisor> must not be zero
         """
-        cdef volatile Obj result
+        cdef Obj result
         try:
             sig_GAP_Enter()
             sig_on()
@@ -1102,7 +1102,7 @@ cdef class GapElement(RingElement):
             GAPError: Error, no method found!
             Error, no 1st choice method found for `mod' on 2 arguments
         """
-        cdef volatile Obj result
+        cdef Obj result
         try:
             sig_GAP_Enter()
             sig_on()
@@ -1150,7 +1150,6 @@ cdef class GapElement(RingElement):
             GAPError: Error, no method found! Error, no 1st choice
             method found for `InverseMutable' on 1 arguments
         """
-        cdef volatile Obj result
         try:
             sig_GAP_Enter()
             sig_on()
@@ -2481,10 +2480,6 @@ cdef class GapElement_Function(GapElement):
             GAPError: Error, no method found!
             Error, no 1st choice method found for `SumOp' on 2 arguments
 
-            sage: rnd=[1,2,3]
-            sage: libgap.Sum(rnd)
-            6
-            
             sage: for i in range(100):
             ....:     rnd = [ randint(-10,10) for i in range(randint(0,7)) ]
             ....:     # compute the sum in GAP
@@ -2500,20 +2495,18 @@ cdef class GapElement_Function(GapElement):
             sage: libgap_exec('echo hello from the shell')
             hello from the shell
         """
-        cdef volatile Obj result = NULL
-        cdef volatile Obj arg_list
+        cdef Obj result = NULL
+        cdef Obj arg_list
         cdef int n = len(args)
         cdef volatile Obj v2
 
         if n > 0 and n <= 3:
             libgap = self.parent()
             a = [x if isinstance(x, GapElement) else libgap(x) for x in args]
 
-        cdef bint sig_on_called = False
         try:
             sig_GAP_Enter()
             sig_on()
-            sig_on_called = True
             if n == 0:
                 result = GAP_CallFunc0Args(self.value)
             elif n == 1:
@@ -2533,12 +2526,6 @@ cdef class GapElement_Function(GapElement):
                 arg_list = make_gap_list(args)
                 result = GAP_CallFuncList(self.value, arg_list)
             sig_off()
-            sig_on_called = False
-        except Exception:
-            # If any exception occurred, ensure we clean up properly
-            if sig_on_called:
-                sig_off()
-            raise
         finally:
             GAP_Leave()
         if result == NULL: