gh-36247: fix E228 and E225 in categories/
    
Fix pycodestyle warnings E228 and E225 in src/sage/categories

This was scripted using autopep8

### 📝 Checklist

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
    
URL: #36247
Reported by: Frédéric Chapoton
Reviewer(s): David Coudert

Author: Release Manager

src/sage/categories/bimodules.py

@@ -118,7 +118,7 @@ def _repr_object_names(self):
             Category of bimodules over Rational Field on the left and Integer Ring on the right
         """
         return "bimodules over %s on the left and %s on the right" \
-            %(self._left_base_ring, self._right_base_ring)
+            % (self._left_base_ring, self._right_base_ring)
 
     def left_base_ring(self):
         """

src/sage/categories/cartesian_product.py

@@ -242,7 +242,7 @@ def _repr_object_names(self):
 
         """
         # This method is only required for the capital `C`
-        return "Cartesian products of %s"%(self.base_category()._repr_object_names())
+        return "Cartesian products of %s" % (self.base_category()._repr_object_names())
 
     def CartesianProducts(self):
         """

src/sage/categories/category.py

@@ -629,7 +629,7 @@ def _latex_(self):
             sage: latex(CommutativeAdditiveSemigroups())
             \mathbf{CommutativeAdditiveSemigroups}
         """
-        return "\\mathbf{%s}"%self._short_name()
+        return "\\mathbf{%s}" % self._short_name()
 
 #   The convention for which hash function to use should be decided at the level of UniqueRepresentation
 #   The implementation below is bad (hash independent of the base ring)
@@ -1452,9 +1452,9 @@ def _test_category(self, **options):
         from sage.categories.sets_cat import Sets
         tester = self._tester(**options)
         tester.assertTrue(isinstance(self.super_categories(), list),
-                       "%s.super_categories() should return a list"%self)
+                       "%s.super_categories() should return a list" % self)
         tester.assertTrue(self.is_subcategory(Objects()),
-                       "%s is not a subcategory of Objects()"%self)
+                       "%s is not a subcategory of Objects()" % self)
         tester.assertTrue(isinstance(self.parent_class, type))
         tester.assertTrue(all(not isinstance(cat, JoinCategory) for cat in self._super_categories))
         if not isinstance(self, JoinCategory):
@@ -1580,7 +1580,7 @@ def _make_named_class(self, name, method_provider, cache=False, picklable=True):
         cls = self.__class__
         if isinstance(cls, DynamicMetaclass):
             cls = cls.__base__
-        class_name = "%s.%s"%(cls.__name__, name)
+        class_name = "%s.%s" % (cls.__name__, name)
         method_provider_cls = getattr(self, method_provider, None)
         if method_provider_cls is None:
             # If the category provides no XXXMethods class,
@@ -1589,10 +1589,10 @@ def _make_named_class(self, name, method_provider, cache=False, picklable=True):
         else:
             # Otherwise, check XXXMethods
             assert inspect.isclass(method_provider_cls),\
-                "%s.%s should be a class"%(cls.__name__, method_provider)
+                "%s.%s should be a class" % (cls.__name__, method_provider)
             mro = inspect.getmro(method_provider_cls)
             if len(mro) > 2 or (len(mro) == 2 and mro[1] is not object):
-                warn("%s.%s should not have a super class"%(cls.__name__, method_provider))
+                warn("%s.%s should not have a super class" % (cls.__name__, method_provider))
             # and point the documentation to it
             doccls = method_provider_cls
         if picklable:

src/sage/categories/category_types.py

@@ -124,7 +124,7 @@ def _repr_object_names(self):
             sage: Elements(ZZ)._repr_object_names()
             'elements of Integer Ring'
         """
-        return "elements of %s"%self.object()
+        return "elements of %s" % self.object()
 
     def _latex_(self):
         r"""
@@ -135,7 +135,7 @@ def _latex_(self):
             sage: latex(x.category())  # indirect doctest                               # needs sage.modules
             \mathbf{Elt}_{\Bold{Q}^{3}}
         """
-        return "\\mathbf{Elt}_{%s}"%latex(self.__object)
+        return "\\mathbf{Elt}_{%s}" % latex(self.__object)
 
 
 #############################################################
@@ -290,7 +290,7 @@ def _repr_object_names(self):
                 name = base._repr_object_names()
         else:
             name = base
-        return Category._repr_object_names(self) + " over %s"%name
+        return Category._repr_object_names(self) + " over %s" % name
 
     def _latex_(self):
         r"""
@@ -299,7 +299,7 @@ def _latex_(self):
             sage: latex(ModulesWithBasis(ZZ))
             \mathbf{ModulesWithBasis}_{\Bold{Z}}
         """
-        return "\\mathbf{%s}_{%s}"%(self._label, latex(self.__base))
+        return "\\mathbf{%s}_{%s}" % (self._label, latex(self.__base))
 
 #    def construction(self):
 #        return (self.__class__, self.__base)
@@ -555,7 +555,7 @@ def _repr_(self):
             sage: Ideals(IntegerRing())
             Category of ring ideals in Integer Ring
         """
-        return Category._repr_(self) + " in %s"%self.__ambient
+        return Category._repr_(self) + " in %s" % self.__ambient
 
 #    def construction(self):
 #        return (self.__class__, self.__ambient)

src/sage/categories/commutative_ring_ideals.py

@@ -42,7 +42,7 @@ def __init__(self, R):
             sage: TestSuite(CommutativeRingIdeals(ZZ)).run()
         """
         if R not in CommutativeRings():
-            raise TypeError("R (=%s) must be a commutative ring"%R)
+            raise TypeError("R (=%s) must be a commutative ring" % R)
         Category_ideal.__init__(self, R)
 
     def super_categories(self):

src/sage/categories/commutative_rings.py

@@ -349,7 +349,7 @@ def cyclotomic_cosets(self, q, cosets=None):
                 try:
                     ~q
                 except ZeroDivisionError:
-                    raise ValueError("%s is not invertible in %s"%(q,self))
+                    raise ValueError("%s is not invertible in %s" % (q,self))
 
                 if cosets is None:
                     rest = set(self)

src/sage/categories/covariant_functorial_construction.py

@@ -199,7 +199,7 @@ def _repr_(self):
             sage: tensor                       # indirect doctest
             The tensor functorial construction
         """
-        return "The %s functorial construction"%self._functor_name
+        return "The %s functorial construction" % self._functor_name
 
     def __call__(self, args, **kwargs):
         """
@@ -494,7 +494,7 @@ def _repr_object_names(self):
             sage: Semigroups().Subquotients()  # indirect doctest
             Category of subquotients of semigroups
         """
-        return "%s of %s"%(Category._repr_object_names(self), self.base_category()._repr_object_names())
+        return "%s of %s" % (Category._repr_object_names(self), self.base_category()._repr_object_names())
 
     def _latex_(self):
         r"""
@@ -508,7 +508,7 @@ def _latex_(self):
             \mathbf{Algebras}(\mathbf{Semigroups})
         """
         from sage.misc.latex import latex
-        return "\\mathbf{%s}(%s)"%(self._short_name(), latex(self.base_category()))
+        return "\\mathbf{%s}(%s)" % (self._short_name(), latex(self.base_category()))
 
 class CovariantConstructionCategory(FunctorialConstructionCategory):
     """

src/sage/categories/crystals.py

@@ -908,7 +908,7 @@ def digraph(self, subset=None, index_set=None):
                     child = x.f(i)
                     if child is None or child not in subset:
                         continue
-                    d[x][child]=i
+                    d[x][child] = i
             G = DiGraph(d)
             from sage.graphs.dot2tex_utils import have_dot2tex
             if have_dot2tex():
@@ -1057,12 +1057,12 @@ def metapost(self, filename, thicklines=False, labels=True, scaling_factor=1.0,
                     c2 = int(35*tallness*scaling_factor)
                     c3 = int(12*scaling_factor)
                     c4 = int(-12*scaling_factor)
-                outstring = "verbatimtex\n\\magnification=600\netex\n\nbeginfig(-1);\nsx:=35; sy:=30;\n\nz1000=(%d,0);\nz1001=(%d,%d);\nz1002=(%d,%d);\nz2001=(-3,3);\nz2002=(3,3);\nz2003=(0,-3);\nz2004=(7,0);\nz2005=(0,7);\nz2006=(-7,0);\nz2007=(0,7);\n\n"%(c0,c1,c2,c3,c4)
+                outstring = "verbatimtex\n\\magnification=600\netex\n\nbeginfig(-1);\nsx:=35; sy:=30;\n\nz1000=(%d,0);\nz1001=(%d,%d);\nz1002=(%d,%d);\nz2001=(-3,3);\nz2002=(3,3);\nz2003=(0,-3);\nz2004=(7,0);\nz2005=(0,7);\nz2006=(-7,0);\nz2007=(0,7);\n\n" % (c0,c1,c2,c3,c4)
             else:
                 if labels:
-                    outstring = "verbatimtex\n\\magnification=600\netex\n\nbeginfig(-1);\n\nsx := %d;\nsy=%d;\n\nz1000=(2*sx,0);\nz1001=(-sx,sy);\nz1002=(-16,-10);\n\nz2001=(0,-3);\nz2002=(-5,3);\nz2003=(0,3);\nz2004=(5,3);\nz2005=(10,1);\nz2006=(0,10);\nz2007=(-10,1);\nz2008=(0,-8);\n\n"%(int(scaling_factor*40),int(tallness*scaling_factor*40))
+                    outstring = "verbatimtex\n\\magnification=600\netex\n\nbeginfig(-1);\n\nsx := %d;\nsy=%d;\n\nz1000=(2*sx,0);\nz1001=(-sx,sy);\nz1002=(-16,-10);\n\nz2001=(0,-3);\nz2002=(-5,3);\nz2003=(0,3);\nz2004=(5,3);\nz2005=(10,1);\nz2006=(0,10);\nz2007=(-10,1);\nz2008=(0,-8);\n\n" % (int(scaling_factor*40),int(tallness*scaling_factor*40))
                 else:
-                    outstring = "beginfig(-1);\n\nsx := %d;\nsy := %d;\n\nz1000=(2*sx,0);\nz1001=(-sx,sy);\nz1002=(-5,-5);\n\nz1003=(10,10);\n\n"%(int(scaling_factor*35),int(tallness*scaling_factor*35))
+                    outstring = "beginfig(-1);\n\nsx := %d;\nsy := %d;\n\nz1000=(2*sx,0);\nz1001=(-sx,sy);\nz1002=(-5,-5);\n\nz1003=(10,10);\n\n" % (int(scaling_factor*35),int(tallness*scaling_factor*35))
             for i in range(size):
                 if self.cartan_type()[0] == 'A':
                     [a1,a2,a3] = string_data[i]
@@ -1079,12 +1079,12 @@ def metapost(self, filename, thicklines=False, labels=True, scaling_factor=1.0,
                         if b1+b3 == a1+a3 and b2+b4 == a2+a4:
                             shift += 1
                 if self.cartan_type()[0] == 'A':
-                    outstring = outstring +"z%d=%d*z1000+%d*z1001+%d*z1002;\n"%(i,a1+a3,a2,shift)
+                    outstring = outstring + "z%d=%d*z1000+%d*z1001+%d*z1002;\n" % (i,a1+a3,a2,shift)
                 else:
-                    outstring = outstring +"z%d=%d*z1000+%d*z1001+%d*z1002;\n"%(i,a1+a3,a2+a4,shift)
+                    outstring = outstring + "z%d=%d*z1000+%d*z1001+%d*z1002;\n" % (i,a1+a3,a2+a4,shift)
             outstring = outstring + "\n"
             if thicklines:
-                outstring = outstring +"pickup pencircle scaled 2\n\n"
+                outstring = outstring + "pickup pencircle scaled 2\n\n"
             for i in range(size):
                 for j in range(1,3):
                     dest = self.list()[i].f(j)
@@ -1096,19 +1096,19 @@ def metapost(self, filename, thicklines=False, labels=True, scaling_factor=1.0,
                             col = "green;  "
                         if self.cartan_type()[0] == 'A':
                             [a1,a2,a3] = string_data[i] # included to facilitate hand editing of the .mp file
-                            outstring = outstring+"draw z%d--z%d withcolor %s   %% %d %d %d\n"%(i,dest,col,a1,a2,a3)
+                            outstring = outstring+"draw z%d--z%d withcolor %s   %% %d %d %d\n" % (i,dest,col,a1,a2,a3)
                         else:
                             [a1,a2,a3,a4] = string_data[i]
-                            outstring = outstring+"draw z%d--z%d withcolor %s   %% %d %d %d %d\n"%(i,dest,col,a1,a2,a3,a4)
+                            outstring = outstring+"draw z%d--z%d withcolor %s   %% %d %d %d %d\n" % (i,dest,col,a1,a2,a3,a4)
             outstring += "\npickup pencircle scaled 3;\n\n"
             for i in range(self.cardinality()):
                 if labels:
                     if self.cartan_type()[0] == 'A':
-                        outstring = outstring+"pickup pencircle scaled 15;\nfill z%d+z2004..z%d+z2006..z%d+z2006..z%d+z2007..cycle withcolor white;\nlabel(btex %d etex, z%d+z2001);\nlabel(btex %d etex, z%d+z2002);\nlabel(btex %d etex, z%d+z2003);\npickup pencircle scaled .5;\ndraw z%d+z2004..z%d+z2006..z%d+z2006..z%d+z2007..cycle;\n"%(i,i,i,i,string_data[i][2],i,string_data[i][1],i,string_data[i][0],i,i,i,i,i)
+                        outstring = outstring+"pickup pencircle scaled 15;\nfill z%d+z2004..z%d+z2006..z%d+z2006..z%d+z2007..cycle withcolor white;\nlabel(btex %d etex, z%d+z2001);\nlabel(btex %d etex, z%d+z2002);\nlabel(btex %d etex, z%d+z2003);\npickup pencircle scaled .5;\ndraw z%d+z2004..z%d+z2006..z%d+z2006..z%d+z2007..cycle;\n" % (i,i,i,i,string_data[i][2],i,string_data[i][1],i,string_data[i][0],i,i,i,i,i)
                     else:
-                        outstring = outstring+"%%%d %d %d %d\npickup pencircle scaled 1;\nfill z%d+z2005..z%d+z2006..z%d+z2007..z%d+z2008..cycle withcolor white;\nlabel(btex %d etex, z%d+z2001);\nlabel(btex %d etex, z%d+z2002);\nlabel(btex %d etex, z%d+z2003);\nlabel(btex %d etex, z%d+z2004);\npickup pencircle scaled .5;\ndraw z%d+z2005..z%d+z2006..z%d+z2007..z%d+z2008..cycle;\n\n"%(string_data[i][0],string_data[i][1],string_data[i][2],string_data[i][3],i,i,i,i,string_data[i][0],i,string_data[i][1],i,string_data[i][2],i,string_data[i][3],i,i,i,i,i)
+                        outstring = outstring+"%%%d %d %d %d\npickup pencircle scaled 1;\nfill z%d+z2005..z%d+z2006..z%d+z2007..z%d+z2008..cycle withcolor white;\nlabel(btex %d etex, z%d+z2001);\nlabel(btex %d etex, z%d+z2002);\nlabel(btex %d etex, z%d+z2003);\nlabel(btex %d etex, z%d+z2004);\npickup pencircle scaled .5;\ndraw z%d+z2005..z%d+z2006..z%d+z2007..z%d+z2008..cycle;\n\n" % (string_data[i][0],string_data[i][1],string_data[i][2],string_data[i][3],i,i,i,i,string_data[i][0],i,string_data[i][1],i,string_data[i][2],i,string_data[i][3],i,i,i,i,i)
                 else:
-                    outstring += "drawdot z%d;\n"%i
+                    outstring += "drawdot z%d;\n" % i
             outstring += "\nendfig;\n\nend;\n\n"
 
             f = open(filename, 'w')
@@ -1153,8 +1153,8 @@ def dot_tex(self):
                     else:
                         option = ""
                         (source, target) = (x, child)
-                    result += "  " + vertex_key(source) + " -> "+vertex_key(target)+ " [ "+option+"label = \" \", texlbl = \""+quoted_latex(i)+"\" ];\n"
-            result+="}"
+                    result += "  " + vertex_key(source) + " -> "+vertex_key(target) + " [ "+option+"label = \" \", texlbl = \""+quoted_latex(i)+"\" ];\n"
+            result += "}"
             return result
 
         def plot(self, **options):

src/sage/categories/dual.py

@@ -36,4 +36,4 @@ def _repr_object_names(self):
             Category of duals of vector spaces over Rational Field
         """
         # Just to remove the `objects`
-        return "duals of %s"%(self.base_category()._repr_object_names())
+        return "duals of %s" % (self.base_category()._repr_object_names())

src/sage/categories/enumerated_sets.py

@@ -742,7 +742,7 @@ def _unrank_from_iterator(self, r):
             for counter, u in enumerate(self):
                 if counter == r:
                     return u
-            raise ValueError("the rank must be in the range from %s to %s"%(0,counter))
+            raise ValueError("the rank must be in the range from %s to %s" % (0,counter))
         unrank = _unrank_from_iterator
 
         def _rank_from_iterator(self, x):