Skip to content

Commit 46027e8

Browse files
author
Release Manager
committed
gh-35980: Adapt to new Singular sat API The `sat` function that returns the saturation exponent was renamed to `sat_with_exp` in [1] This patch makes Sage work with singular < 4.3.2p3 and > 4.3.2p4. With 4.3.2p3 and 4.3.2p4 it returns a wrong exponent [2], unless singular is patched with the above commit. [1] Singular/Singular@3f7e01a0f1f77073a3bc0dd3 25260ea88c216aff [2] Singular/Singular#1181 URL: #35980 Reported by: Antonio Rojas Reviewer(s): Kwankyu Lee
2 parents f12752d + 535b63a commit 46027e8

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

src/sage/rings/polynomial/multi_polynomial_ideal.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2460,7 +2460,11 @@ def saturation(self, other):
24602460
(Ideal (y, x^5) of Multivariate Polynomial Ring in x, y, z over Algebraic Field, 4)
24612461
"""
24622462
from sage.libs.singular.function_factory import ff
2463-
sat = ff.elim__lib.sat
2463+
# function renamed in singular > 4.3.2p4, see issue #35980
2464+
try:
2465+
sat = ff.elim__lib.sat_with_exp
2466+
except NameError:
2467+
sat = ff.elim__lib.sat
24642468
R = self.ring()
24652469
ideal, expo = sat(self, other)
24662470
return (R.ideal(ideal), ZZ(expo))

0 commit comments

Comments
 (0)